Skip to content

Get GMP building on Apple Silicon #57315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claui merged 10 commits into from
Jul 6, 2020
Merged

Get GMP building on Apple Silicon #57315

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
379f7b6
Get GMP building on Apple Silicon
BytesGuy Jul 2, 2020
9665d01
Update gmp.rb
BytesGuy Jul 2, 2020
6496e11
Attempt ASM patch
BytesGuy Jul 3, 2020
036c6a2
Fix with autoreconf
BytesGuy Jul 3, 2020
1c49840
Resolve style error
BytesGuy Jul 3, 2020
a9f4108
gmp: clarify patch is temporary
claui Jul 3, 2020
57e49c8
gmp: fix brew test/linkage issue on arm64
claui Jul 3, 2020
7b1d75b
Restore config flags and tidy arm depends
BytesGuy Jul 4, 2020
77beee8
gmp: use consolidated formula patch
claui Jul 4, 2020
aad0270
gmp: update patch SHA265 after rebase
claui Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion Formula/gmp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,34 @@ class Gmp < Formula

uses_from_macos "m4" => :build

patch do
# Remove when upstream fix is released
# https://gmplib.org/list-archives/gmp-bugs/2020-July/004837.html
# arm64-darwin patch
url "https://raw.githubusercontent.com/Homebrew/formula-patches/c53834b4/gmp/6.2.0-arm.patch"
sha256 "4c5b926f47c78f9cc6f900130d020e7f3aa6f31a6e84246e8886f6da04f7424c"
end

if Hardware::CPU.arm?
depends_on "autoconf" => :build
depends_on "automake" => :build
depends_on "libtool" => :build
end

def install
# Work around macOS Catalina / Xcode 11 code generation bug
# (test failure t-toom53, due to wrong code in mpn/toom53_mul.o)
ENV.append_to_cflags "-fno-stack-check"

# Enable --with-pic to avoid linking issues with the static library
args = %W[--prefix=#{prefix} --enable-cxx --with-pic]
args << "--build=#{Hardware.oldest_cpu}-apple-darwin#{`uname -r`.to_i}"

if Hardware::CPU.arm?
args << "--build=aarch64-apple-darwin#{`uname -r`.to_i}"
system "autoreconf", "-fiv"
else
args << "--build=#{Hardware.oldest_cpu}-apple-darwin#{`uname -r`.to_i}"
end
system "./configure", *args
system "make"
system "make", "check"
Expand Down