itk 4.13.2 (new formula)

[fblupi]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

Moving formula from homebrew-sci as they say they don't keep maintaining the repo. I have renamed the formula from insighttoolkit to itk and updated it to a more recent version.

[BrewTestBot]

• New formulae should not have a bottle do block

[fxcoudert]

  * Non-libraries were installed to "/usr/local/opt/itk/lib"
    Installing non-libraries to "lib" is discouraged.
    The offending files are:
      /usr/local/opt/itk/lib/itkLIBMINCConfig.cmake
            /usr/local/opt/itk/lib/UseitkLIBMINC.cmake

[fblupi]

• New formulae should not have a bottle do block

Fixed

• Non-libraries were installed to "/usr/local/opt/itk/lib"
  Installing non-libraries to "lib" is discouraged.
  The offending files are:
  /usr/local/opt/itk/lib/itkLIBMINCConfig.cmake
  /usr/local/opt/itk/lib/UseitkLIBMINC.cmake

I think I can't do anything to solve this. I can't detect what cmake option is generating the cmake file in the lib folder and the formula from the homebrew-sci repo generate this cmake file too.

[fxcoudert]

the formula from the homebrew-sci repo generate this cmake file too

That does not make it suitable for homebrew-core.

[zbeekman]

libminc (vendored by itk) needs updating it's CMakeLists.txt. I've added a patch, and submitted a PR to ITK, which is being investigated upstream of that by MINC too.

@fblupi do you mind if I force push to your branch with my changes (and rebased onto a more recent homebrew-core/master)?

[zbeekman]

@fblupi I hope you don't mind: I'm going to force push to your branch so that this can get tested with CI.

[fblupi]

@zbeekman No problem. Feel free :)

[BrewTestBot]

• Formulae should not require patches to build. Patches should be submitted and accepted upstream first.

[zbeekman]

Yes, we know brew testbot...

[zbeekman]

@fxcoudert what are your thoughts on merging it? It looks like the upstream of the upstream is patching this, and the upstream package is going to incorporate that patch.

[zbeekman]

Thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

[fblupi]

Thank you too @zbeekman for your help with the issue I had! 🍻