dlib, r, scalapack: build with openblas#35694
Closed
fxcoudert wants to merge 3 commits intoHomebrew:masterfrom
Closed
dlib, r, scalapack: build with openblas#35694fxcoudert wants to merge 3 commits intoHomebrew:masterfrom
fxcoudert wants to merge 3 commits intoHomebrew:masterfrom
Conversation
fxcoudert
added
do not merge
ready to merge
Member
Author
|
@BrewTestBot test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three formulas were
openblaswas an optional dependency, and we make it the default. Apple's Accelerate framework has issues, which have lead us to switch some formulas to depend onopenblasinstead. This seems like a popular choice (fewer bugs, higher performance), and probably a good default.This PR should wait until #35609 is merged, to make things simpler.