Skip to content

Comments

opencv 4.0.1#35521

Closed
fxcoudert wants to merge 7 commits intoHomebrew:masterfrom
fxcoudert:opencv-4.0.1
Closed

opencv 4.0.1#35521
fxcoudert wants to merge 7 commits intoHomebrew:masterfrom
fxcoudert:opencv-4.0.1

Conversation

@fxcoudert
Copy link
Member

@fxcoudert fxcoudert commented Dec 28, 2018

No description provided.

@fxcoudert
Copy link
Member Author

fxcoudert commented Dec 28, 2018 •
edited
Loading

@fxcoudert
Copy link
Member Author

fxcoudert commented Dec 28, 2018 •
edited
Loading

@fxcoudert fxcoudert force-pushed the opencv-4.0.1 branch 2 times, most recently from c3ef7a8 to 6925bd3 Compare December 28, 2018 21:43
@fxcoudert
Copy link
Member Author

fxcoudert commented Dec 28, 2018 •
edited
Loading

From siril upstream (https://gitlab.com/free-astro/siril/issues/296):

OpenCV 4 […] is not supported by the old siril. You have to use the git version or wait for the next release that will come in a few days to weeks.

So: depending on a opencv@3 for now. Taking the opportunity to clean up some opencv@2 options.

@fxcoudert
Copy link
Member Author

fxcoudert commented Dec 30, 2018

Sadly the siril build issue is preexisting. Not sure what to do next.

@fxcoudert fxcoudert mentioned this pull request Jan 2, 2019
Closed
6 tasks
@fxcoudert fxcoudert mentioned this pull request Jan 4, 2019
Closed
@fxcoudert
Copy link
Member Author

fxcoudert commented Jan 4, 2019

Found the issue: siril cannot be compiled with GCC when opencv is compiled with clang. So we drop OpenMP support in siril.

@fxcoudert fxcoudert closed this in 9adee66 Jan 5, 2019
@fxcoudert fxcoudert deleted the opencv-4.0.1 branch January 5, 2019 09:36
@fxcoudert
Copy link
Member Author

fxcoudert commented Jan 5, 2019 •
edited
Loading

Merged, but: gmic Mojave bottle got corrupted somehow, so I'm building a new one real quick. https://jenkins.brew.sh/job/Homebrew%20Testing/1132/

@fxcoudert
Copy link
Member Author

fxcoudert commented Jan 5, 2019

gmic bottle fixed in 67e666a

@purcell purcell mentioned this pull request Jan 7, 2019
Closed
5 tasks
@lock lock bot added the outdated PR was locked due to age label Feb 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fxcoudert