Skip to content

zeromq 4.3.0#34568

Closed
igas wants to merge 1 commit intoHomebrew:masterfrom
igas:zeromq-4.3.0
Closed

zeromq 4.3.0#34568
igas wants to merge 1 commit intoHomebrew:masterfrom
igas:zeromq-4.3.0

Conversation

@igas
Copy link

@igas igas commented Nov 28, 2018

Created with brew bump-formula-pr.

@fxcoudert
Copy link
Member

fxcoudert commented Nov 29, 2018

This is hit by the infamous:

In file included from src/v2_decoder.cpp:33:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/cmath:313:9: error: no member named 'signbit' in the global namespace

on High Sierra. Trying to fix it, and removing options at the same time (#31510).

@scpeters
Copy link
Contributor

@BrewTestBot test this please

@scpeters
Copy link
Contributor

I can reproduce the signbit build error on high sierra with the current version of the formula (4.2.5)

@igas igas added help wanted Task(s) needing PRs from the community or maintainers build failure CI fails while building the software labels Dec 17, 2018
@igas
Copy link
Author

igas commented Dec 22, 2018

@BrewTestBot test this please

@emielwiedijk
Copy link
Contributor

emielwiedijk commented Jan 1, 2019

It seems to be a problem with the options added by superenv. If the build system calls clang directly by adding ENV["CXX"] = "/usr/bin/clang++", the build completes fine.

Edit: Commit Homebrew/brew@eea18a5 broke the build. It works with that commit reverted.

@emielwiedijk
Copy link
Contributor

The workaround works with ENV.delete("HOMEBREW_SDKROOT").

@igas
Copy link
Author

igas commented Jan 2, 2019

Thank you @aimileus!

@igas igas removed build failure CI fails while building the software help wanted Task(s) needing PRs from the community or maintainers labels Jan 3, 2019
@fxcoudert fxcoudert closed this in f31e838 Jan 4, 2019
@igas igas deleted the zeromq-4.3.0 branch January 5, 2019 09:14
@bluca
Copy link
Contributor

bluca commented Jan 12, 2019

@igas hi, could you please update the formula to the newly released 4.3.1 as soon as you have time? Unfortunately I do not have OSX to do it myself. The new version fixes a remote execution vulnerability: https://github.com/zeromq/libzmq/releases/tag/v4.3.1
Thanks!

@emielwiedijk
Copy link
Contributor

I opened a new PR at #35940

@lock lock bot added the outdated PR was locked due to age label Feb 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants