Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi-generator 3.0.0 (new formula) #28584

Closed
wants to merge 4 commits into from

Conversation

wing328
Copy link
Contributor

@wing328 wing328 commented Jun 2, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@wing328
Copy link
Contributor Author

wing328 commented Jun 2, 2018

  • GitHub repository too new (<30 days old)

OpenAPI Generator is a fork of Swagger Codegen as explained in https://github.com/OpenAPITools/openapi-generator/blob/master/docs/qna.md and Swagger Codegen (https://github.com/swagger-api/swagger-codegen) was created a few years back.

@commitay commitay changed the title openapi-generator-3.0.0 openapi-generator 3.0.0 (new formula) Jun 2, 2018
@commitay commitay added the new formula PR adds a new formula to Homebrew/homebrew-core label Jun 2, 2018
@wing328
Copy link
Contributor Author

wing328 commented Jun 2, 2018

@wing328
Copy link
Contributor Author

wing328 commented Jun 3, 2018

@ilovezfs I wonder if you can review and give an exception for this case as OpenAPI Generator is a fork of Swagger Codegen as explained in https://github.com/OpenAPITools/openapi-generator/blob/master/docs/qna.md and Swagger Codegen (https://github.com/swagger-api/swagger-codegen) was created a few years back.

Please let me know if you've any question.

@ships
Copy link

ships commented Jun 9, 2018

@wing328 in the meantime, do you maintain a tap elsewhere that this formula can be pulled from?

@wing328
Copy link
Contributor Author

wing328 commented Jun 9, 2018

@jraqula sorry we don't. This formula should be ready for merge in a few days.

created_at: "2018-05-12T09:57:56Z",

@philsturgeon
Copy link

source

@MartinDelille
Copy link
Contributor

  1. As you can see here, openapi-generator is much more active than swagger-codegen:
  1. openapi-generator handle OpenAPI specification v3 when swagger-codegen support only v2.

@MartinDelille
Copy link
Contributor

Why can't we see the build result? I have a 404 error.

@wing328
Copy link
Contributor Author

wing328 commented Jun 12, 2018

Closing this one as I've opened a new one for OpenAPI Generator 3.0.1 instead: #28921

@wing328 wing328 closed this Jun 12, 2018
@lock lock bot added the outdated PR was locked due to age label Jul 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants