Skip to content

openjdk 26.0.1#279619

Merged
BrewTestBot merged 14 commits into
Homebrew:mainfrom
ashr123:openjdk-26
May 20, 2026
Merged

openjdk 26.0.1#279619
BrewTestBot merged 14 commits into
Homebrew:mainfrom
ashr123:openjdk-26

Conversation

@ashr123

@ashr123 ashr123 commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

@github-actions github-actions Bot added CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long dependent tests Set a long timeout for dependent testing labels Apr 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@ashr123

ashr123 commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

I’ll be happy for some help as I don’t know what is missing

@ashr123

ashr123 commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

help wanted

@ashr123

ashr123 commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

@copilot help wanted, fix this PR

@GunniBusch

This comment was marked as resolved.

@cv3x

cv3x commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Perhaps it would make more sense to introduce a dedicated openjdk@25.rb formula for the current LTS release, as mentioned in my earlier comment here.

Then, for this openjdk.rb formula tracking the latest release, you could add an openjdk@26 alias to reflect the current version.

@ashr123

ashr123 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

@Calvinit I'll be able to handle it on the 30th

@cv3x cv3x mentioned this pull request Apr 28, 2026
6 tasks
@GunniBusch

Copy link
Copy Markdown
Contributor

Perhaps it would make more sense to introduce a dedicated openjdk@25.rb formula for the current LTS release, as mentioned in my earlier comment here.

Then, for this openjdk.rb formula tracking the latest release, you could add an openjdk@26 alias to reflect the current version.

I think we should do it the other way around. Have the non lts version versioned and the unversioned is the lts

@ashr123

ashr123 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

@GunniBusch I don’t think this is how it is currently works, as I see, only LTS versions are versioned and openjdk.rb contains the latest formula

@github-actions github-actions Bot added automerge-skip `brew pr-automerge` will skip this pull request alias labels Apr 30, 2026
@ashr123

ashr123 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

@calvinit, @GunniBusch it seems like the following caused the failuer this time:

brew test --retry --verbose glassfish
brew test --retry --verbose opensearch

Can you elaborate on that?

@github-actions github-actions Bot added the new formula PR adds a new formula to Homebrew/homebrew-core label May 1, 2026
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@ashr123

ashr123 commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

See #278720

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

Comment thread Formula/o/openjdk@25.rb
@GunniBusch

Copy link
Copy Markdown
Contributor

it seems like the following caused the failuer this time:

brew test --retry --verbose glassfish
brew test --retry --verbose opensearch

Can you elaborate on that?

Everything that doesn’t work with 26.0.1, just replace openjdk with openjdk@25 inkl. all the references inside the formulae.

@cv3x

cv3x commented May 19, 2026

Copy link
Copy Markdown
Contributor

What do we need to do now to move this PR forward?

I asked GitHub Copilot, and its suggestion was:

Re-run the PR with CI-no-fail-fast-deps so the cancelled tests run does not cause test_deps to be skipped.

@GunniBusch

Copy link
Copy Markdown
Contributor

What do we need to do now to move this PR forward?

I asked GitHub Copilot, and its suggestion was:

Re-run the PR with CI-no-fail-fast-deps so the cancelled tests run does not cause test_deps to be skipped.

We can’t test deps if the formulae whose deps to test were not build.

SMillerDev and others added 7 commits May 19, 2026 17:23
Co-authored-by: Roy Ash <roy.ash456@gmail.com>
Co-authored-by: Roy Ash <roy.ash456@gmail.com>
Co-authored-by: Roy Ash <roy.ash456@gmail.com>
Co-authored-by: Roy Ash <roy.ash456@gmail.com>
Co-authored-by: Roy Ash <roy.ash456@gmail.com>
Co-authored-by: Roy Ash <roy.ash456@gmail.com>
Co-authored-by: Roy Ash <roy.ash456@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 20, 2026
@BrewTestBot BrewTestBot enabled auto-merge May 20, 2026 06:35
@BrewTestBot BrewTestBot added this pull request to the merge queue May 20, 2026
Merged via the queue into Homebrew:main with commit 5975e29 May 20, 2026
20 checks passed
@ashr123

ashr123 commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

I've executed

brew update -f && brew upgrade
brew install openjdk@26

but I got

Warning: No available formula with the name "openjdk@26". Did you mean openjdk, openjdk@21, openjdk@8, openjdk@17 or openjdk@11?

Why is that?

@daeho-ro

Copy link
Copy Markdown
Member

Rebottle for arm is done.
In order to get the latest one, brew upgrade openjdk or install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alias automerge-skip `brew pr-automerge` will skip this pull request CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing new formula PR adds a new formula to Homebrew/homebrew-core workflows PR modifies GitHub Actions workflow files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants