Skip to content

go@1.24: add patch to fix pkg-config flag sanitization#266080

Merged
BrewTestBot merged 2 commits intomainfrom
go-1.24-pkg-config-issue
Feb 6, 2026
Merged

go@1.24: add patch to fix pkg-config flag sanitization#266080
BrewTestBot merged 2 commits intomainfrom
go-1.24-pkg-config-issue

Conversation

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula labels Feb 5, 2026
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 force-pushed the go-1.24-pkg-config-issue branch from 0c463f7 to ba3b71a Compare February 5, 2026 23:14
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Feb 6, 2026
@stefanb
Copy link
Member

stefanb commented Feb 6, 2026

Will merging this just reduce the visibility of upstream

?

It is needed in our go formula for the navidrome formula (ref #265724 ) , but go@1.24 currently has no such dependent formula.

If we do merge this, should we also consider all upstream issues? 😅
https://dev.golang.org/release#Go1.24.14
https://github.com/golang/go/milestone/425

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@chenrui333
Copy link
Member Author

chenrui333 commented Feb 6, 2026

It is needed in our go formula for the navidrome formula (ref #265724 ) , but go@1.24 currently has no such dependent formula.

yeah, internally, we dont have such formula, but it would be also used externally too.

If we do merge this, should we also consider all upstream issues? 😅

if it has obvious user impact, we should consider?

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 6, 2026
@BrewTestBot BrewTestBot enabled auto-merge February 6, 2026 06:45
@chenrui333
Copy link
Member Author

Side note, this is not for go, we have done something similar for nodejs before.

@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 2de4aa4 Feb 6, 2026
22 checks passed
@BrewTestBot BrewTestBot deleted the go-1.24-pkg-config-issue branch February 6, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants