Skip to content

pipewire 1.4.9 (new formula) - #254211

Merged
BrewTestBot merged 2 commits into
Homebrew:mainfrom
ReenigneArcher:add-libpipewire
Nov 15, 2025
Merged

pipewire 1.4.9 (new formula)#254211
BrewTestBot merged 2 commits into
Homebrew:mainfrom
ReenigneArcher:add-libpipewire

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Nov 13, 2025

Copy link
Copy Markdown
Contributor
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This formula is linux only. I tried to build it on macOS anyway, but it failed. Not worth putting any effort in to actually get it to compile on macOS since the library is intended for Linux.

@github-actions github-actions Bot added new formula PR adds a new formula to Homebrew/homebrew-core linux-only Formula depends on Linux meson Meson use is a significant feature of the PR or issue labels Nov 13, 2025
@ReenigneArcher
ReenigneArcher force-pushed the add-libpipewire branch 4 times, most recently from f6188f3 to 8129fe5 Compare November 13, 2025 04:01
@ReenigneArcher
ReenigneArcher marked this pull request as ready for review November 13, 2025 04:29

@ReenigneArcher ReenigneArcher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference

Comment thread Formula/p/pipewire.rb
@ReenigneArcher

This comment was marked as resolved.

@botantony botantony added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 13, 2025
@chenrui333

Copy link
Copy Markdown
Member

This formula is linux only. I tried to build it on macOS anyway, but it failed

what was the error? might worth creating an upstream issue for it?

@ReenigneArcher

ReenigneArcher commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

what was the error? might worth creating an upstream issue for it?

Probably pointless to do that. It's a Linux only project.

image

The failure is here: https://github.com/Homebrew/homebrew-core/actions/runs/19320619307/job/55261406191

Comment thread Formula/lib/libpipewire.rb Outdated
Comment thread Formula/lib/libpipewire.rb Outdated
Comment thread Formula/lib/libpipewire.rb Outdated
@cho-m cho-m changed the title libpipewire 1.5.83 (new formula) pipewire 1.4.9 (new formula) Nov 13, 2025
@cho-m

cho-m commented Nov 13, 2025

Copy link
Copy Markdown
Member

Error may be build trying to install udev rules to system path?

  Installing /var/tmp/pipewire-20251113-23258-cc5yqs/pipewire-1.4.9/spa/plugins/alsa/90-pipewire-alsa.rules to /usr/lib/udev/rules.d

Can try seeing if installing them into prefix like -Dudevrulesdir=#{lib}/udev/rules.d works. We commonly install these files in that path even if they aren't used.

@ReenigneArcher

This comment was marked as outdated.

@ReenigneArcher
ReenigneArcher requested a review from cho-m November 14, 2025 05:23
@chenrui333 chenrui333 added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 14, 2025

@chenrui333 chenrui333 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cho-m

cho-m commented Nov 14, 2025

Copy link
Copy Markdown
Member

Will need one more git rebase to pull in a change needed to allow merge to go through. Otherwise PR will fail some checks during automerge.

Also, would be nice to copy over the livecheck from libdex before merge which will fix brew lc pipewire to avoid the unstable versions:

livecheck do
url :stable
regex(/^v?(\d+\.\d*[02468](?:\.\d+)*)$/i)
end

@github-actions github-actions Bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Nov 15, 2025
Co-Authored-By: Michael Cho <20700669+cho-m@users.noreply.github.com>
@ReenigneArcher

Copy link
Copy Markdown
Contributor Author

Added live check, rebased, and added @cho-m as a co-author. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

馃 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 15, 2025
@BrewTestBot
BrewTestBot added this pull request to the merge queue Nov 15, 2025
Merged via the queue into Homebrew:main with commit 7b31a48 Nov 15, 2025
19 checks passed
@ReenigneArcher
ReenigneArcher deleted the add-libpipewire branch November 15, 2025 21:26
@ReenigneArcher

Copy link
Copy Markdown
Contributor Author

Any idea why homebrew would hang when trying to install this? My workflow is timing out at 6 hours.

https://github.com/LizardByte/Sunshine/actions/runs/19383741336/job/55485840129#step:8:1076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. linux-only Formula depends on Linux meson Meson use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants