Skip to content

Conversation

botantony
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has to be done in two steps (add py3.12 and drop py3.13) as cryptography needs python-setuptools

@botantony botantony force-pushed the setuptools-python-3.14 branch 2 times, most recently from 6851286 to ba720db Compare October 9, 2025 19:35
Copy link
Contributor

github-actions bot commented Oct 9, 2025

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

⚠️ Bottle publish failed.

@botantony botantony force-pushed the setuptools-python-3.14 branch from ba720db to 37be71b Compare October 9, 2025 20:09
@botantony
Copy link
Member Author

there is a problem with /usr/local replaced with HOMEBREW_PREFIX

diff --color -r ./python-setuptools-sonoma/80.9.0_1/lib/python3.14/site-packages/setuptools/_vendor/platformdirs-4.2.2.dist-info/METADATA ./python-setuptools-arm64-sonoma/80.9.0_1/lib/python3.14/site-packages/setuptools/_vendor/platformdirs-4.2.2.dist-info/METADATA
171c171
<     '/usr/local/share/SuperApp'
---
>     '@@HOMEBREW_PREFIX@@/share/SuperApp'
173c173
<     '/usr/local/share/SuperApp:/usr/share/SuperApp'
---
>     '@@HOMEBREW_PREFIX@@/share/SuperApp:/usr/share/SuperApp'
196c196
<     >>> os.environ["XDG_CONFIG_DIRS"] = "/etc:/usr/local/etc"
---
>     >>> os.environ["XDG_CONFIG_DIRS"] = "/etc:@@HOMEBREW_PREFIX@@/etc"
198c198
<     '/etc/SuperApp:/usr/local/etc/SuperApp'
---
>     '/etc/SuperApp:@@HOMEBREW_PREFIX@@/etc/SuperApp'

# More diffs like this below

Let's see if we do not need to inreplace inreplace_files, "/usr/local", HOMEBREW_PREFIX

Copy link
Contributor

github-actions bot commented Oct 9, 2025

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@botantony botantony force-pushed the setuptools-python-3.14 branch from 37be71b to f17a3e8 Compare October 9, 2025 20:12
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

⚠️ Bottle publish failed.

@botantony botantony force-pushed the setuptools-python-3.14 branch from f17a3e8 to 2acd56d Compare October 9, 2025 21:36
Copy link
Contributor

github-actions bot commented Oct 9, 2025

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

⚠️ Bottle publish failed.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

⚠️ Bottle publish failed.

@daeho-ro daeho-ro force-pushed the setuptools-python-3.14 branch from 2acd56d to 3251198 Compare October 10, 2025 02:06
Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@daeho-ro
Copy link
Member

Let's keep the old behavior for keg relocation, it's a bit dirty to handle. I have opened a PR for this but not sure it can be accepted or not.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 10, 2025
@daeho-ro daeho-ro force-pushed the setuptools-python-3.14 branch from 3251198 to 4b0073b Compare October 10, 2025 02:47
@daeho-ro daeho-ro added the ready to merge PR can be merged once CI is green label Oct 10, 2025
@botantony botantony removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 10, 2025
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 10, 2025
@BrewTestBot BrewTestBot enabled auto-merge October 10, 2025 13:04
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 10, 2025
Merged via the queue into main with commit b085c20 Oct 10, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the setuptools-python-3.14 branch October 10, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python-3.14-migration ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants