Skip to content

openai-whisper: use llvm@20 (pre-release testing)#235317

Closed
cho-m wants to merge 1 commit into
mainfrom
openai-whisper-llvm20
Closed

openai-whisper: use llvm@20 (pre-release testing)#235317
cho-m wants to merge 1 commit into
mainfrom
openai-whisper-llvm20

Conversation

@cho-m

@cho-m cho-m commented Aug 28, 2025

Copy link
Copy Markdown
Member

Testing pre-releases of llvmlite and numba

CMake addition is for llvmlite. Same for environment variable changes:

RC tracking issues:


Tested:

  • system libexec/"bin/python", "-m", "llvmlite.tests"
  • system libexec/"bin/python", "-m", "numba.runtests", "-m"

@cho-m cho-m added pre-release Artifact is pre-release prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Aug 28, 2025
@github-actions github-actions Bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue ffmpeg FFMPEG use is a significant feature of the PR or issue labels Aug 28, 2025
@cho-m cho-m added the in progress Stale bot should stay away label Aug 28, 2025
@esc

esc commented Aug 29, 2025

Copy link
Copy Markdown

@cho-m looks like the test failure was some sort of glitch that caused a timeout?

Context: Numba release manager here, I am checking on dependents and the stability of the release candidate.

@cho-m

cho-m commented Aug 29, 2025

Copy link
Copy Markdown
Member Author

@cho-m looks like the test failure was some sort of glitch that caused a timeout?

Yeah, you can ignore the failure as it is unrelated to numba/llvmlite. Likely a slow CI runner.

@cho-m cho-m force-pushed the openai-whisper-llvm20 branch from b9408df to fbeb122 Compare August 29, 2025 19:05
Comment on lines +94 to +97

# TODO: remove
system libexec/"bin/python", "-m", "llvmlite.tests"
system libexec/"bin/python", "-m", "numba.runtests", "-m"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove on a future run. Just checking our shared LLVM 20 works with llvmlite via test suite:

Suggested change
# TODO: remove
system libexec/"bin/python", "-m", "llvmlite.tests"
system libexec/"bin/python", "-m", "numba.runtests", "-m"

@esc

esc commented Sep 1, 2025

Copy link
Copy Markdown

FWIW: using a shared LLVM is somewhat discouraged and this setup has been removed in conda-forge: conda-forge/llvmlite-feedstock#100 -- in case you end up with user issues and weird segfaults, this may be something to consider.

@cho-m cho-m added the not merged PR was closed without being merged (and may need to be revisited) label Sep 11, 2025
@cho-m

cho-m commented Sep 11, 2025

Copy link
Copy Markdown
Member Author

Closing until stable releases are available

@cho-m cho-m closed this Sep 11, 2025
@p-linnane p-linnane deleted the openai-whisper-llvm20 branch September 15, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. ffmpeg FFMPEG use is a significant feature of the PR or issue in progress Stale bot should stay away not merged PR was closed without being merged (and may need to be revisited) pre-release Artifact is pre-release prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants