[wip] llgo:pretest embed customize clang#235127
Conversation
9334c0c to
98834fb
Compare
ff9344c to
90e9f09
Compare
90e9f09 to
35a4ee5
Compare
35a4ee5 to
c998fac
Compare
4381294 to
9ea3b7f
Compare
1c86904 to
7a06605
Compare
|
Hi @carlocab , |
7a06605 to
d8c4896
Compare
|
Hi @chenrui333 , hope you're having a great day! |
llvm build cache with mac cgo config with c++17 -Wl,-rpath with llvm remove CFLAG unset by xgo-dev/llgo#1243 merged with llgo embed target build test DRUNTIMES_CMAKE_ARGS set RPATH clang prefix linux rpath -DLLVM_ENABLE_LIBEDIT=OFF refine rb struct llvm test off remove some llvm component as tinygo build only nessary executable -DLLVM_INSTALL_UTILS=OFF
d8c4896 to
9cf2d49
Compare
| resource "espressif-llvm" do | ||
| url "https://github.com/espressif/llvm-project.git", | ||
| revision: "xtensa_release_19.1.2", | ||
| shallow: true | ||
| end |
There was a problem hiding this comment.
What are your plans for upstreaming your changes from this fork?
We're not that keen on another custom build of LLVM here.
There was a problem hiding this comment.
@carlocab Thank you for your feedback!
I appreciate you bringing this up! We don't actually maintain or fork Espressif's LLVM repository—our executable simply uses it as a compiler to support building code for Xtensa architecture chips (such as ESP32) in llgo.
From what I understand, Espressif is actively working on upstreaming their Xtensa modifications to LLVM mainline. You can track their progress here: Tracking Issue for merging to upstream (LLVM-57) · Issue #4 · espressif/llvm-project.
We're also hoping this formula can eventually be merged into Homebrew/core, which would allow users to access it directly through the standard brew install llgo command without needing additional taps or custom configurations. This would greatly improve llgo's accessibility and community adoption.
There was a problem hiding this comment.
I'm not convinced that this formula is sufficiently popular to warrant the maintenance burden of yet another custom LLVM build here, I'm afraid. (See analytics data here.)
It looks to me that @espressif releases binary builds of their toolchain (example), so what we should probably do is stick with the LLVM formula here, but make it easier for users to use a custom toolchain with this formula.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Agreeing with @carlocab above, and closing for now. This feels beyond the scope of what Homebrew ships. Probably good match for a personal tap: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?feature
verify in follow platform