Skip to content

Comments

ola: revision bump (abseil 20250512.1)#233009

Merged
BrewTestBot merged 2 commits intoHomebrew:mainfrom
branchv:ola
Aug 15, 2025
Merged

ola: revision bump (abseil 20250512.1)#233009
BrewTestBot merged 2 commits intoHomebrew:mainfrom
branchv:ola

Conversation

@branchv
Copy link
Member

@branchv branchv commented Aug 10, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Broken linkage seen in #232580

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Aug 10, 2025
@carlocab
Copy link
Member

Needs fixes to build. See #232571

@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Aug 14, 2025
@cho-m cho-m added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Aug 14, 2025
@cho-m cho-m changed the title ola: revision bump (abseil 20250127.1) ola: revision bump (abseil 20250512.1) Aug 14, 2025
@cho-m cho-m force-pushed the ola branch 2 times, most recently from c87f58a to aa134f7 Compare August 15, 2025 00:07
@cho-m cho-m added ready to merge PR can be merged once CI is green and removed ready to merge PR can be merged once CI is green labels Aug 15, 2025
@cho-m cho-m force-pushed the ola branch 3 times, most recently from 57f4334 to bfdcee2 Compare August 15, 2025 03:26
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Aug 15, 2025
@cho-m
Copy link
Member

cho-m commented Aug 15, 2025

Skipping some tests on macOS which may just be flaky. Existing bottles are broken so I think we should just merge.

Can deal with 15-arm64 later. Failure will temporarily go away in Xcode 16.4 as Apple restored the deprecated behavior that LLVM removed. May fail again in Tahoe release.

@carlocab carlocab mentioned this pull request Aug 15, 2025
6 tasks
@github-actions
Copy link
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 15, 2025
@BrewTestBot BrewTestBot enabled auto-merge August 15, 2025 12:30
@carlocab
Copy link
Member

We may want to apply the patches at #232571 so that the headers here work on Xcode 16.3, at least?

@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 15, 2025
Merged via the queue into Homebrew:main with commit 7af9dca Aug 15, 2025
19 checks passed
@cho-m
Copy link
Member

cho-m commented Aug 15, 2025

We may want to apply the patches at #232571 so that the headers here work on Xcode 16.3, at least?

I don't think it fixes LLVM 19+ error which looks due to usage of std::basic_string<uint8_t> at https://github.com/OpenLightingProject/ola/blob/master/include/ola/io/ByteString.h#L40

At least the char_trait failures are often due to not using a standard specialization https://en.cppreference.com/w/cpp/string/char_traits.html and relying on generic implementation (https://reviews.llvm.org/D157058)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants