cmd/check-bottle-modification: fix handling of removed files#230832
Merged
cmd/check-bottle-modification: fix handling of removed files#230832
Conversation
carlocab
added
ready to merge
github-actions
bot
added
automerge-skip
This comment was marked as resolved.
This comment was marked as resolved.
carlocab
changed the title
carlocab
force-pushed
the
fix-formula-renames
branch
from
4b40e68 to
58987bd
Compare
github-actions
bot
removed
the
new formula
6 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the handling of removed files in the check-bottle-modification command and addresses issues with formula renames. The changes prevent errors when formulas are removed and improve the logic for filtering relevant files.
- Skip processing of removed files to prevent errors during formula removal/rename operations
- Fix the formula path filtering to use correct "Formula/" prefix instead of "Formula"
Bo98
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to error out here if a formula is removed. This is also
fixes handling of formula renames. See, for example, #230744 or #230831.