Skip to content

Conversation

@botantony
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jul 17, 2025
@botantony
Copy link
Member Author

need to wait for new version of https://pypi.org/project/pyarrow

@amoeba
Copy link
Contributor

amoeba commented Jul 18, 2025

@botantony PyArrow 21.0.0 is now on PyPi: https://pypi.org/project/pyarrow/.

@botantony botantony force-pushed the bump-apache-arrow-21.0.0 branch from d5b31be to 703cec0 Compare July 18, 2025 03:13
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 20, 2025
@botantony
Copy link
Member Author

in progress

@github-actions github-actions bot removed the stale No recent activity label Jul 20, 2025
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 22, 2025
amoeba added a commit to amoeba/PDAL that referenced this pull request Jul 22, 2025
This call to NewRowGroup was deprecated in Arrow 19.0.0 because
the implementation wasn't using it,

apache/arrow#45048

The deprecated variant of NewRowGroup was removed in Arrow 21.0.0
so this change will make PDAL compile cleanly against Arrow
21.0.0.

See Homebrew/homebrew-core#230431.
@amoeba
Copy link
Contributor

amoeba commented Jul 22, 2025

This PR seems stalled due to breakage in dependencies of the apache-arrow formula. I filed PDAL/PDAL#4773 to hopefully fix the current pdal failure but the glances formula failure doesn't make sense to me.

@botantony do you have a fix in mind?

@github-actions github-actions bot removed the stale No recent activity label Jul 22, 2025
@botantony botantony force-pushed the bump-apache-arrow-21.0.0 branch from 703cec0 to f954744 Compare July 22, 2025 20:02
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@botantony Feel free to ping me next time if you need a label to keep stalebot away.

@p-linnane p-linnane added the long build Set a long timeout for formula testing label Jul 22, 2025
hobu added a commit to PDAL/PDAL that referenced this pull request Jul 23, 2025
* Fix deprecation in ArrowWriter.cpp

This call to NewRowGroup was deprecated in Arrow 19.0.0 because
the implementation wasn't using it,

apache/arrow#45048

The deprecated variant of NewRowGroup was removed in Arrow 21.0.0
so this change will make PDAL compile cleanly against Arrow
21.0.0.

See Homebrew/homebrew-core#230431.

* check for ARROW_VERSION_MAJOR>=20

---------

Co-authored-by: Howard Butler <[email protected]>
hobu pushed a commit to PDAL/PDAL that referenced this pull request Jul 23, 2025
This call to NewRowGroup was deprecated in Arrow 19.0.0 because
the implementation wasn't using it,

apache/arrow#45048

The deprecated variant of NewRowGroup was removed in Arrow 21.0.0
so this change will make PDAL compile cleanly against Arrow
21.0.0.

See Homebrew/homebrew-core#230431.
hobu added a commit to PDAL/PDAL that referenced this pull request Jul 23, 2025
…21.0.0 (#4775)

* Fix deprecation in ArrowWriter.cpp

This call to NewRowGroup was deprecated in Arrow 19.0.0 because
the implementation wasn't using it,

apache/arrow#45048

The deprecated variant of NewRowGroup was removed in Arrow 21.0.0
so this change will make PDAL compile cleanly against Arrow
21.0.0.

See Homebrew/homebrew-core#230431.

* check for ARROW_VERSION_MAJOR>=20

---------

Co-authored-by: Bryce Mecum <[email protected]>
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 25, 2025
@kou
Copy link
Contributor

kou commented Jul 25, 2025

Should we apply PDAL/PDAL#4773 as a patch or should we wait for a new PDAL release?

It seems that a new PDAL release will happen in a few weeks:

PDAL/PDAL#4773 (comment)

2.9.1 with this fix will hopefully be released end of next week or first week of August.

@github-actions github-actions bot removed the stale No recent activity label Jul 25, 2025
@amoeba
Copy link
Contributor

amoeba commented Jul 25, 2025

I think it'd be best to apply the pdal patch, in the interest of time. It looks like vineyard is still failing but I'm not sure why.

@amoeba
Copy link
Contributor

amoeba commented Jul 25, 2025

@botantony I think you could apply something like this,

commit 734b919a1c59c4fe087dd26138fa7d691eb1365c
Author: Bryce Mecum <[email protected]>
Date:   Thu Jul 24 19:15:13 2025 -0700

    Add patch for pdal

diff --git a/Formula/p/pdal.rb b/Formula/p/pdal.rb
index 1cf4233e6ef..a342d6d5a85 100644
--- a/Formula/p/pdal.rb
+++ b/Formula/p/pdal.rb
@@ -48,6 +48,15 @@ class Pdal < Formula
     depends_on "libunwind"
   end
 
+  # Patch to support [email protected]
+  #
+  # Can be removed once pdal updates to 2.9.1
+  # See https://github.com/PDAL/PDAL/pull/4773
+  patch do
+    url "https://github.com/PDAL/PDAL/commit/8deb4e577ab6a73e74cd720256e1d574509ea3e9.patch?full_index=1"
+    sha256 "be2f614ea3c81129f94b8e8e8b7d696e9d43cfef9b5cc2b25cab567c2c06936c"
+  end
+
   def install
     args = %w[
       -DWITH_TESTS=OFF

@botantony botantony force-pushed the bump-apache-arrow-21.0.0 branch from f954744 to 562e17f Compare July 25, 2025 06:36
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 27, 2025
@BrewTestBot BrewTestBot enabled auto-merge July 27, 2025 15:24
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 27, 2025
Merged via the queue into Homebrew:main with commit 1578047 Jul 27, 2025
19 checks passed
@botantony botantony deleted the bump-apache-arrow-21.0.0 branch July 27, 2025 15:38
@amoeba
Copy link
Contributor

amoeba commented Jul 28, 2025

Thanks @carlocab

carlocab added a commit that referenced this pull request Jul 28, 2025
@carlocab carlocab mentioned this pull request Jul 28, 2025
6 tasks
carlocab added a commit that referenced this pull request Jul 28, 2025
carlocab added a commit that referenced this pull request Jul 28, 2025
carlocab added a commit that referenced this pull request Jul 28, 2025
carlocab added a commit that referenced this pull request Jul 29, 2025
carlocab added a commit that referenced this pull request Jul 29, 2025
carlocab added a commit that referenced this pull request Jul 29, 2025
carlocab added a commit that referenced this pull request Jul 29, 2025
carlocab added a commit that referenced this pull request Jul 29, 2025
carlocab added a commit that referenced this pull request Jul 29, 2025
carlocab added a commit that referenced this pull request Jul 29, 2025
I _think_ this should fix the Intel macOS failures.

Follow-up to #230431
carlocab added a commit that referenced this pull request Jul 29, 2025
I _think_ this should fix the Intel macOS failures.

Follow-up to #230431
carlocab added a commit that referenced this pull request Jul 29, 2025
I _think_ this should fix the Intel macOS failures.

Follow-up to #230431
carlocab added a commit that referenced this pull request Jul 29, 2025
I _think_ this should fix the Intel macOS failures.

Follow-up to #230431
@carlocab
Copy link
Member

Intel macOS bottles for vineyard should be fixed by #231443.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants