-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
apache-arrow apache-arrow-glib 21.0.0 #230431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apache-arrow apache-arrow-glib 21.0.0 #230431
Conversation
|
need to wait for new version of https://pypi.org/project/pyarrow |
|
@botantony PyArrow 21.0.0 is now on PyPi: https://pypi.org/project/pyarrow/. |
d5b31be to
703cec0
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
|
in progress |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
This call to NewRowGroup was deprecated in Arrow 19.0.0 because the implementation wasn't using it, apache/arrow#45048 The deprecated variant of NewRowGroup was removed in Arrow 21.0.0 so this change will make PDAL compile cleanly against Arrow 21.0.0. See Homebrew/homebrew-core#230431.
|
This PR seems stalled due to breakage in dependencies of the apache-arrow formula. I filed PDAL/PDAL#4773 to hopefully fix the current pdal failure but the glances formula failure doesn't make sense to me. @botantony do you have a fix in mind? |
703cec0 to
f954744
Compare
p-linnane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@botantony Feel free to ping me next time if you need a label to keep stalebot away.
* Fix deprecation in ArrowWriter.cpp This call to NewRowGroup was deprecated in Arrow 19.0.0 because the implementation wasn't using it, apache/arrow#45048 The deprecated variant of NewRowGroup was removed in Arrow 21.0.0 so this change will make PDAL compile cleanly against Arrow 21.0.0. See Homebrew/homebrew-core#230431. * check for ARROW_VERSION_MAJOR>=20 --------- Co-authored-by: Howard Butler <[email protected]>
This call to NewRowGroup was deprecated in Arrow 19.0.0 because the implementation wasn't using it, apache/arrow#45048 The deprecated variant of NewRowGroup was removed in Arrow 21.0.0 so this change will make PDAL compile cleanly against Arrow 21.0.0. See Homebrew/homebrew-core#230431.
…21.0.0 (#4775) * Fix deprecation in ArrowWriter.cpp This call to NewRowGroup was deprecated in Arrow 19.0.0 because the implementation wasn't using it, apache/arrow#45048 The deprecated variant of NewRowGroup was removed in Arrow 21.0.0 so this change will make PDAL compile cleanly against Arrow 21.0.0. See Homebrew/homebrew-core#230431. * check for ARROW_VERSION_MAJOR>=20 --------- Co-authored-by: Bryce Mecum <[email protected]>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
|
Should we apply PDAL/PDAL#4773 as a patch or should we wait for a new PDAL release? It seems that a new PDAL release will happen in a few weeks:
|
|
I think it'd be best to apply the pdal patch, in the interest of time. It looks like vineyard is still failing but I'm not sure why. |
|
@botantony I think you could apply something like this, commit 734b919a1c59c4fe087dd26138fa7d691eb1365c
Author: Bryce Mecum <[email protected]>
Date: Thu Jul 24 19:15:13 2025 -0700
Add patch for pdal
diff --git a/Formula/p/pdal.rb b/Formula/p/pdal.rb
index 1cf4233e6ef..a342d6d5a85 100644
--- a/Formula/p/pdal.rb
+++ b/Formula/p/pdal.rb
@@ -48,6 +48,15 @@ class Pdal < Formula
depends_on "libunwind"
end
+ # Patch to support [email protected]
+ #
+ # Can be removed once pdal updates to 2.9.1
+ # See https://github.com/PDAL/PDAL/pull/4773
+ patch do
+ url "https://github.com/PDAL/PDAL/commit/8deb4e577ab6a73e74cd720256e1d574509ea3e9.patch?full_index=1"
+ sha256 "be2f614ea3c81129f94b8e8e8b7d696e9d43cfef9b5cc2b25cab567c2c06936c"
+ end
+
def install
args = %w[
-DWITH_TESTS=OFF |
f954744 to
562e17f
Compare
|
Thanks @carlocab |
I _think_ this should fix the Intel macOS failures. Follow-up to #230431
I _think_ this should fix the Intel macOS failures. Follow-up to #230431
I _think_ this should fix the Intel macOS failures. Follow-up to #230431
I _think_ this should fix the Intel macOS failures. Follow-up to #230431
|
Intel macOS bottles for |
Created by
brew bumpCreated with
brew bump-formula-pr.