Skip to content

Conversation

@gregnazario
Copy link
Contributor

@gregnazario gregnazario commented Jun 5, 2025

Upgrade to latest Rust version and release 7.4.0 of the Aptos CLI. Since we updated to the latest Rust version, we can get rid of the patch.

Replaces #225645

  • [] Have you followed the guidelines for contributing?
  • [] Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Upgrade to latest Rust version and release 7.4.0 of the Aptos CLI
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Jun 5, 2025
@SMillerDev
Copy link
Member

    error occurred in cc-rs: command did not execute successfully (status code exit status: 1): env -u IPHONEOS_DEPLOYMENT_TARGET LC_ALL="C" "clang" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=arm64-apple-macosx" "-mmacosx-version-min=15.4" "-Wall" "-Wextra" "-fno-omit-frame-pointer" "-mno-avx" "-fno-builtin" "-Wno-unused-function" "-Wno-unused-command-line-argument" "-o" "/private/tmp/aptos-20250605-7616-6rospv/aptos-core-aptos-cli-v7.4.0/target/cli/build/blst-d1179c99129b50de/out/3ce72ea41a6346fd-server.o" "-c" "/Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/index.crates.io-1949cf8c6b5b557f/blst-0.3.11/blst/src/server.c"

@gregnazario
Copy link
Contributor Author

    error occurred in cc-rs: command did not execute successfully (status code exit status: 1): env -u IPHONEOS_DEPLOYMENT_TARGET LC_ALL="C" "clang" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=arm64-apple-macosx" "-mmacosx-version-min=15.4" "-Wall" "-Wextra" "-fno-omit-frame-pointer" "-mno-avx" "-fno-builtin" "-Wno-unused-function" "-Wno-unused-command-line-argument" "-o" "/private/tmp/aptos-20250605-7616-6rospv/aptos-core-aptos-cli-v7.4.0/target/cli/build/blst-d1179c99129b50de/out/3ce72ea41a6346fd-server.o" "-c" "/Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/index.crates.io-1949cf8c6b5b557f/blst-0.3.11/blst/src/server.c"

Hmm still an issue with supranational/blst#253

@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. 15-arm64 Sequoia arm64 is specifically affected labels Jun 6, 2025
@gregnazario
Copy link
Contributor Author

So, what I see here is there seems to be something strange with the exact environment used to build.

It's reproducible on my mac when in the same environment as the build, but when I run the same exact build command on my mac without the environment, it breaks.

@chenrui333
Copy link
Member

So, what I see here is there seems to be something strange with the exact environment used to build.

I think this is related to supranational/blst#253

I am gonna adopt the similar patch used for lighthouse, #225877 into #225645

@chenrui333
Copy link
Member

Should be good now, closing this PR in favor of #225645

@chenrui333 chenrui333 closed this Jun 9, 2025
@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Jun 9, 2025
@chenrui333
Copy link
Member

  warning: [email protected]: clang: error: unsupported option '-mno-avx' for target 'arm64-apple-macosx'
  warning: [email protected]: ToolExecError: command did not execute successfully (status code exit status: 1): env -u IPHONEOS_DEPLOYMENT_TARGET LC_ALL="C" "clang" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=arm64-apple-macosx" "-mmacosx-version-min=15.4" "-Wall" "-Wextra" "-fno-omit-frame-pointer" "-mno-avx" "-fno-builtin" "-Wno-unused-function" "-Wno-unused-command-line-argument" "-o" "/private/tmp/aptos-20250605-7634-q6g8ci/aptos-core-aptos-cli-v7.4.0/target/cli/build/blst-d1179c99129b50de/out/3ce72ea41a6346fd-server.o" "-c" "/Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/index.crates.io-1949cf8c6b5b557f/blst-0.3.11/blst/src/server.c"
  error: failed to run custom build command for `blst v0.3.11`
  
  Caused by:
    process didn't exit successfully: `/private/tmp/aptos-20250605-7634-q6g8ci/aptos-core-aptos-cli-v7.4.0/target/cli/build/blst-12d3ea2a4c056193/build-script-build` (exit status: 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

15-arm64 Sequoia arm64 is specifically affected CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. rust Rust use is a significant feature of the PR or issue superseded PR was replaced by another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants