-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure-cli 2.0.21 #20654
azure-cli 2.0.21 #20654
Conversation
@@ -1,8 +1,8 @@ | |||
class AzureCli < Formula | |||
desc "Microsoft Azure CLI 2.0" | |||
homepage "https://docs.microsoft.com/cli/azure/overview" | |||
url "https://azurecliprod.blob.core.windows.net/releases/azure-cli-2.0.20.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decommissioned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous files will still be there. We will not remove them.
From now on though, we release based of a specific git tag so now we can just point to the github release archive. It seems this is more standard across package managers to just point to the GitHub archive if it's available.
(Previously, the .tar.gz was custom so we had to create it and host it ourselves)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekbekoe you may still want to upload separate release artifacts to GitHub, even if you're just downloading the source archive tarball and reuploading it, to avoid getting caught up in this sort of situation #18044.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay.
I changed the URL to https://azurecliprod.blob.core.windows.net/releases/azure-cli-2.0.21.tar.gz.
Does that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, that will be safer.
Added to commit to fix CI. |
Thanks for the upgrade @derekbekoe! ❇️ |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?