Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-cli 2.0.21 #20654

Closed
wants to merge 3 commits into from
Closed

Conversation

derekbekoe
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@@ -1,8 +1,8 @@
class AzureCli < Formula
desc "Microsoft Azure CLI 2.0"
homepage "https://docs.microsoft.com/cli/azure/overview"
url "https://azurecliprod.blob.core.windows.net/releases/azure-cli-2.0.20.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decommissioned?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous files will still be there. We will not remove them.
From now on though, we release based of a specific git tag so now we can just point to the github release archive. It seems this is more standard across package managers to just point to the GitHub archive if it's available.

(Previously, the .tar.gz was custom so we had to create it and host it ourselves)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekbekoe you may still want to upload separate release artifacts to GitHub, even if you're just downloading the source archive tarball and reuploading it, to avoid getting caught up in this sort of situation #18044.

Copy link
Contributor Author

@derekbekoe derekbekoe Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that will be safer.

@derekbekoe
Copy link
Contributor Author

derekbekoe commented Nov 15, 2017

Added to commit to fix CI.
Please merge when ready if it looks good to you.

@ilovezfs
Copy link
Contributor

Thanks for the upgrade @derekbekoe! ❇️

@ilovezfs ilovezfs closed this in 45e9dda Nov 15, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants