Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whisperkit-cli 0.10.0 #201854

Conversation

argmaxincbot
Copy link
Contributor

@github-actions github-actions bot added swift Swift use is a significant feature of the PR or issue macos-only Formula depends on macOS labels Dec 20, 2024
@chenrui333
Copy link
Member

/private/tmp/whisperkit-cli-20241219-4581-qfyxme/WhisperKit-0.10.0/Sources/WhisperKit/Core/Utils/Utils.swift:113:18: error: cannot find type 'MLTensor' in scope
  public extension MLTensor {
                   ^~~~~~~~
  /private/tmp/whisperkit-cli-20241219-4581-qfyxme/WhisperKit-0.10.0/Sources/WhisperKit/Core/Text/TokenSampler.swift:38:32: error: cannot find 'MLTensor' in scope
              var logitsTensor = MLTensor(MLShapedArray<FloatType>(logits)).cast(to: Float.self)
                                 ^~~~~~~~
  /private/tmp/whisperkit-cli-20241219-4581-qfyxme/WhisperKit-0.10.0/Sources/WhisperKit/Core/Text/TokenSampler.swift:39:34: error: cannot find type 'MLTensor' in scope
              var nextTokenTensor: MLTensor
                                   ^~~~~~~~
  /private/tmp/whisperkit-cli-20241219-4581-qfyxme/WhisperKit-0.10.0/Sources/WhisperKit/Core/Text/TokenSampler.swift:40:36: error: cannot find type 'MLTensor' in scope
              var nextLogprobTensor: MLTensor
                                     ^~~~~~~~
  /private/tmp/whisperkit-cli-20241219-4581-qfyxme/WhisperKit-0.10.0/Sources/WhisperKit/Core/Text/TokenSampler.swift:56:59: error: binary operator '*' cannot be applied to operands of type 'SIMDMask<_>' and 'Double'
                  accumTopKProbs += (accumTopKProbs .< rnd) * [100](https://github.com/Homebrew/homebrew-core/actions/runs/12423012268/job/34685906596?pr=201854#step:3:101).0
                                    ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~
  /private/tmp/whisperkit-cli-20241219-4581-qfyxme/WhisperKit-0.10.0/Sources/WhisperKit/Core/Text/TokenSampler.swift:56:59: note: overloads for '*' exist with these partially matching parameter lists: (Double, Double), (Duration, Double)
                  accumTopKProbs += (accumTopKProbs .< rnd) * 100.0
                                                            ^
  /private/tmp/whisperkit-cli-20241219-4581-qfyxme/WhisperKit-0.10.0/Sources/WhisperKit/Core/TextDecoder.swift:216:13: warning: variable 'prefilledDecoderInputs' was never mutated; consider changing to 'let' constant
          var prefilledDecoderInputs = decoderInputs
          ~~~ ^
          let
  error: fatalError

@chenrui333 chenrui333 added the build failure CI fails while building the software label Dec 20, 2024
@ZachNagengast
Copy link
Contributor

Need to add a compiler flag for this section, we have version checks but not compiler checks, will push a patch shortly.

@daeho-ro
Copy link
Member

Superseded by

@daeho-ro daeho-ro closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build failure CI fails while building the software macos-only Formula depends on macOS swift Swift use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants