Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]: apply fixes for TCL 9 #201830

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 19, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Waiting on reviews to upstream PR.

@cho-m cho-m added upstream issue An upstream issue report is needed blocked labels Dec 19, 2024
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Dec 19, 2024
@cho-m cho-m added in progress Stale bot should stay away maintainer feedback Additional maintainers' opinions may be needed automerge-skip `brew pr-automerge` will skip this pull request and removed blocked labels Dec 20, 2024
@cho-m cho-m marked this pull request as ready for review December 21, 2024 18:23
@cho-m
Copy link
Member Author

cho-m commented Dec 21, 2024

May consider merging this prior to upstream review given user issues.

@w8sl
Copy link

w8sl commented Dec 22, 2024

@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Dec 22, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 22, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 22, 2024
Merged via the queue into master with commit 4b8d2c7 Dec 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away maintainer feedback Additional maintainers' opinions may be needed python Python use is a significant feature of the PR or issue upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants