Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sile 0.15.7 #200370

Closed
wants to merge 1 commit into from
Closed

sile 0.15.7 #200370

wants to merge 1 commit into from

Conversation

daeho-ro
Copy link
Member

@daeho-ro daeho-ro commented Dec 7, 2024

bump alternative


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added lua Lua use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Dec 7, 2024
@alerque
Copy link
Contributor

alerque commented Dec 12, 2024

Nope—v0.15.6 and v0.15.7 were both broken on Darwin anyway as noted in other PRs. I'm going to update the original PR for v0.15.8 which should be fixed upstream now. I suggest closing this.

Formula/s/sile.rb Outdated Show resolved Hide resolved
sile: remove patch
@daeho-ro
Copy link
Member Author

daeho-ro commented Dec 12, 2024

Or just close by 0.15.8 PR?

@alerque
Copy link
Contributor

alerque commented Dec 12, 2024

Or just close by 0.15.8 PR?

I already updated #197800 with v0.15.8. If there is a problem with that lets review it there and not fiddle with new PRs.

@SMillerDev SMillerDev closed this Dec 12, 2024
@github-actions github-actions bot deleted the bump-sile-0.15.7 branch December 12, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icu4c ICU use is a significant feature of the PR or issue lua Lua use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants