Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo: build an :all bottle #191545

Merged
merged 2 commits into from
Sep 22, 2024
Merged

redo: build an :all bottle #191545

merged 2 commits into from
Sep 22, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Our bottles differ only by a symlink. On macOS, the symlink points to
/bin/dash, while on Linux it points to /usr/bin/dash.

There typically is a /bin/dash on Linux too, so let's just use that.

Our bottles differ only by a symlink. On macOS, the symlink points to
`/bin/dash`, while on Linux it points to `/usr/bin/dash`.

There typically is a `/bin/dash` on Linux too, so let's just use that.
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Sep 22, 2024
@carlocab
Copy link
Member Author

All checksums match ✅

15950166170b2edc6aabeea2454d89b024e7f3ad086879bc4d88a413288ce7e1
15950166170b2edc6aabeea2454d89b024e7f3ad086879bc4d88a413288ce7e1
15950166170b2edc6aabeea2454d89b024e7f3ad086879bc4d88a413288ce7e1
15950166170b2edc6aabeea2454d89b024e7f3ad086879bc4d88a413288ce7e1
15950166170b2edc6aabeea2454d89b024e7f3ad086879bc4d88a413288ce7e1
15950166170b2edc6aabeea2454d89b024e7f3ad086879bc4d88a413288ce7e1

@carlocab carlocab marked this pull request as ready for review September 22, 2024 19:48
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Sep 22, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 22, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 22, 2024
Merged via the queue into master with commit 458cb80 Sep 22, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the redo-all branch September 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants