Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
This change allows Dolt to create multiple indexes on a table to cover the same set of columns, to match MySQL's behavior. While duplicate indexes are not generally useful, some MySQL tooling (e.g. Django) can create duplicate indexes as part of generated schema migration code.
Test for creating duplicate indexes were added to GMS, in the PR below. I also tested merge behavior with duplicate indexes and confirmed that we already have a guardrail in place to prevent merging multiple indexes that cover the same set of columns, and a test for that guardrail.
GMS PR: Adding tests for supporting duplicate secondary indexes dolthub/go-mysql-server#2634
Customer issue: Adding a duplicate constraint with a new name overwrites the existing constraint rather than coexisting dolthub/dolt#8254
Fixes Panic when creating index on generated column dolthub/dolt#8269
We were removing the ColumnDefaultValue expression node when building secondary indexes, which was a problem when the type of the default value needed to be converted to the column type: it's the ColumnDefaultValue expression that does that conversion.
install.sh
and fixed all the errors and warning that had obvious fixes. The only one left islocal error_code="$1"
infail
function that should be removed but may be reused for debugging purposes by manually editing the scriptThis is the read only addition of the
dolt_workspace_{table}
s. These dynamically generated tables are always relative to HEAD for the given session of the caller. There are no commits as a result, and the schema of the output looks like:| ID (int) | STAGED (bool) | DIFF_TYPE (string) | to_A | to_B | ... | from_A | from_B | ... |
Currently there is no mechanism to update this table directly, but in the future that will make it possible to have fine grain modification of your workspace, similar to
git add --patch
go-mysql-server
These tests verify the correctness of ResolveDefaultExpression should return a ColumnDefaultValue instance, because it has information about the type of the column and performs conversions. dolthub/dolt#8273.
Some of the checks in these tests are skipped because they run afoul of
SHOW CREATE
doesn't show indexes on virtual generated columns: dolthub/dolt#8275 and Indexes on virtual generated columns generate incorrect results. dolthub/dolt#8276New tests asserting that multiple indexes over the same set of columns can be created on tables.
Allow duplicate indexes, to match MySQL behavior dolthub/dolt#8274 fixes Dolt for these tests to pass.
update
anddelete
triggerspartially fixes nested (delete) triggers have the wrong context in the nested call dolthub/dolt#8213
sql.QFlagMax1Row
shortcut.benchmarks here: [no-release-notes] range select perf bump dolthub/dolt#8241
Closed Issues
--empty
flag for handling empty commits during rebase