-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update GitHub tarball sha256 hashes #18073
Conversation
Thanks @peff! 🙇♂️ Do you mind splitting this into one commit per formula? |
@ilovezfs Done. |
@peff thanks. It looks like the osquery commit took teleport along for the ride :) |
May need to rebase your local repo since teleport was fixed already in 447ae95. |
These are due to non-byte-stable updates to GitHub's generated archives.
These are due to non-byte-stable updates to GitHub's generated archives.
Whoops, apparently I'm incompetent at using Git. Should be fixed now. |
Hehe. You made me think of https://xkcd.com/1597/ |
Thanks for the great scripts and your first contribution to Homebrew, @peff! |
@ilovezfs Let me know if you'd like me to run the same scripts on another set of formulas. I wrote them in such a way that anybody could run and reproduce, but obviously they run a lot faster from inside GitHub's datacenter. |
@ilovezfs Sorry, for some reason I totally missed your response earlier. I just ran it over those other repositories. |
GitHub recently applied an old Git bugfix to their servers (git/git@22f0dcd), which caused the byte representation of some tarballs to change.
I computed the mapping of old to new tarballs by building two versions of git, with and without that commit, and then computing the archive hash for each case. I used this script (note the "git.with" and "git.without" builds were in my $PATH):
That script generated 94 entries. With that output saved to the file "map", I was then able to adjust the hashes in place:
and commit the result. Note that there aren't 94 updates in this commit, because the previous commits had already picked up most of these changes.
/cc @ilovezfs #18044