Skip to content

allureofthestars: remove store-dir#178572

Merged
BrewTestBot merged 2 commits intomasterfrom
allureofthestars-no-store-dir
Jul 27, 2024
Merged

allureofthestars: remove store-dir#178572
BrewTestBot merged 2 commits intomasterfrom
allureofthestars-no-store-dir

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Jul 26, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Draft until #178439 is finished. EDIT: will be easier to merge this first.

Original reason for --store-dir in #67259 was for font files.

In current version, I don't see runtime error, which may be due to AllureOfTheStars/Allure@bff6348

@github-actions github-actions bot added the haskell Haskell use is a significant feature of the PR or issue label Jul 26, 2024
@cho-m cho-m force-pushed the allureofthestars-no-store-dir branch from 6c6feb3 to 9ce4a99 Compare July 26, 2024 20:02
@cho-m cho-m marked this pull request as ready for review July 26, 2024 20:03
@cho-m cho-m force-pushed the allureofthestars-no-store-dir branch from 9ce4a99 to 15961ba Compare July 26, 2024 20:03
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Jul 26, 2024
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 27, 2024
@BrewTestBot BrewTestBot enabled auto-merge July 27, 2024 03:55
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 27, 2024
Merged via the queue into master with commit c26c2d5 Jul 27, 2024
@BrewTestBot BrewTestBot deleted the allureofthestars-no-store-dir branch July 27, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. haskell Haskell use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants