Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avrdude: add libserialport dep #162937

Closed
wants to merge 0 commits into from
Closed

avrdude: add libserialport dep #162937

wants to merge 0 commits into from

Conversation

MCUdude
Copy link

@MCUdude MCUdude commented Feb 16, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Avrdure needs to be built with libserialport to provide a richer serial port experience

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. labels Feb 16, 2024
@MCUdude
Copy link
Author

MCUdude commented Feb 16, 2024

BTW, the libserialport version that brew builds is 0.1.1, and is old. On top of that, I recently discovered a libserialport bug (with every simple fix) that makes it useless for many USB-to-serial adapters on macOS.

Ideally, that PR should be merged immediately as the solution is obvious. However, I'm not able to get in touch with any of the developers. I've tried to tag them on Github, and reach out by sending an email, but without luck.

Would it be possible to provide a fork of libserialport that Avrdude could rely on, instead of the broken 0.1.1 version? The Avrdude project could absolutely host their own, known good version of libserialport.

I'm new to the whole contributing side of things here, so I don't know what your policy is on forks.

@chenrui333 chenrui333 changed the title Avrdude libserialport avrdude: add libserialport dep Feb 17, 2024
@chenrui333
Copy link
Member

chenrui333 commented Feb 17, 2024

@MCUdude 👋 thanks for your first PR to homebrew-core! Can you squash your commits into one and use "avrdude: add libserialport dep" as commit msg? Thanks!

@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Feb 17, 2024
@MCUdude
Copy link
Author

MCUdude commented Feb 17, 2024

@chenrui333 The more I try to fix the commit history, the more comments from others are added to this PR!
Do you know how to fix this, or do I have to create a new PR?

@MCUdude MCUdude closed this Feb 17, 2024
@MCUdude MCUdude mentioned this pull request Feb 17, 2024
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosquash Automatically squash pull request commits according to Homebrew style. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants