Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-cli: patch to build with pyyaml6 #137367

Merged
merged 2 commits into from
Jul 28, 2023
Merged

azure-cli: patch to build with pyyaml6 #137367

merged 2 commits into from
Jul 28, 2023

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

relates to:

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Jul 23, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 23, 2023
Merged
1 task
@chenrui333 chenrui333 force-pushed the azure-cli-patch-pyyaml branch from f8c4158 to 174fd9b Compare July 24, 2023 00:00
@chenrui333 chenrui333 changed the title azure-cli: patch to build with cython 3+ azure-cli: patch to build with pyyaml 6+ Jul 24, 2023
@chenrui333 chenrui333 changed the title azure-cli: patch to build with pyyaml 6+ azure-cli: patch to build with pyyaml6 Jul 24, 2023
@SMillerDev
Copy link
Member

This should be upstreamed

@chenrui333
Copy link
Member Author

it is already in the upstream, they just need to cut a new release (the patch does not get applied cleanly)

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jul 24, 2023
@SMillerDev
Copy link
Member

Did that change also apply to the template that upstream uses to push formula updates?

@chenrui333 chenrui333 requested a review from SMillerDev July 24, 2023 11:55
@chenrui333
Copy link
Member Author

chenrui333 commented Jul 24, 2023 •
edited
Loading

Did that change also apply to the template that upstream uses to push formula updates?

yeah, it would be on the next PR (that is also the reason why I did not add pyyaml ad dependency, but rather just a resource)

They said the next PR would be on August 1st.

@chenrui333 chenrui333 requested a review from branchvincent July 26, 2023 04:12
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions
Copy link
Contributor

⚠️ Bottle publish failed. CC @carlocab

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions
Copy link
Contributor

⚠️ Bottle publish failed. CC @carlocab

@chenrui333
Copy link
Member Author 

time="2023-07-26T09:34:55Z" level=fatal msg="Uploading manifest list failed, attempted the following formats: application/vnd.oci.image.index.v1+json(uploading manifest 2.50.0_1 to ghcr.io/homebrew/core/azure-cli: received unexpected HTTP status: 502 Bad Gateway)"

@chenrui333 chenrui333 added the manifest-issue Bottle manifest is corrupt and cannot be merged label Jul 28, 2023
@github-actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions
Copy link
Contributor

⚠️ @chenrui333 bottle publish failed. CC @carlocab

@SMillerDev SMillerDev force-pushed the azure-cli-patch-pyyaml branch from 174fd9b to d395bb0 Compare July 28, 2023 12:32
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 28, 2023
@BrewTestBot BrewTestBot enabled auto-merge July 28, 2023 13:35
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 28, 2023
Merged via the queue into Homebrew:master with commit 3eb8e30 Jul 28, 2023
@bebound bebound mentioned this pull request Aug 3, 2023
Merged
3 tasks
jiasli
jiasli reviewed Aug 3, 2023
View reviewed changes
Formula/azure-cli.rb
@@ -784,3 +791,18 @@ def install
assert_equal azure_cloud["endpoints"]["resourceManager"], "https://management.azure.com/"
end
end

__END__
diff --git a/tools/setup.py b/tools/setup.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tools/setup.py is actually not used as part of Azure CLI installation at all, so this patch is unnecessary.

@chenrui333 chenrui333 deleted the azure-cli-patch-pyyaml branch January 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiasli jiasli jiasli left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

@branchvincent branchvincent branchvincent approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. manifest-issue Bottle manifest is corrupt and cannot be merged python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenrui333 @SMillerDev @jiasli @branchvincent @BrewTestBot