bloaty: use unversioned protobuf
#135589
Merged
bloaty: use unversioned protobuf
#135589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
force-pushed
the
bloaty-protobuf
branch
2 times, most recently
from
7fcd460
to
f8dd5f2
Compare
|
Upstreamed at google/bloaty#347. |
Needed for Homebrew#132437. We need to apply a patch to avoid using the vendored `abseil`, which will conflict with the one pulled in by our Protobuf.
carlocab
commented
Jul 2, 2023
| @@ -1,7 +1,6 @@ | |||
| class Bloaty < Formula | |||
| desc "Size profiler for binaries" | |||
| homepage "https://github.com/google/bloaty" | |||
| # TODO: Check if we can use unversioned `protobuf` at version bump | |||
There was a problem hiding this comment.
I've omitted the revision bump since this will likely get one in #132437 soon-ish.
p-linnane
approved these changes
Jul 2, 2023
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Needed for #132437.
We need to apply a patch to avoid using the vendored
abseil, whichwill conflict with the one pulled in by our Protobuf.
Will upstream the patch if it works in CI.