Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse-odbc: revision bump (icu4c 73.2) #133684

Merged

Conversation

carlocab
Copy link
Member

See #133611.

@carlocab carlocab added the CI-skip-dependents Pass --skip-dependents to brew test-bot. label Jun 14, 2023
@github-actions github-actions bot added the icu4c ICU use is a significant feature of the PR or issue label Jun 14, 2023
@carlocab
Copy link
Member Author

This is using a really old vendored version of folly: https://github.com/facebook/folly/tree/b817015da18c9f121f376d033fa47450651cd6ef

@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jun 15, 2023
@carlocab carlocab force-pushed the clickhouse-odbc-icu4c-73.2 branch from 938c80b to 1f95a68 Compare June 15, 2023 00:49
@carlocab
Copy link
Member Author

@github-actions
Copy link
Contributor

@carlocab bottle request for clickhouse-odbc failed.

@carlocab
Copy link
Member Author

Ok, so this builds on master. Weird.

@carlocab
Copy link
Member Author

Ah, got it. The issue is, indeed, their old vendored copy of folly: facebook/folly#1867

@carlocab carlocab force-pushed the clickhouse-odbc-icu4c-73.2 branch from 1f95a68 to b9319f4 Compare June 15, 2023 12:50
@github-actions github-actions bot added the formula deprecated Formula deprecated label Jun 15, 2023
Comment on lines 17 to 20
sha256 cellar: :any, arm64_ventura: "9861a2a1c4cfd5e91da5bac18199324b960daaebd6d6c2cd63641a51124fa80e"
sha256 cellar: :any, arm64_monterey: "7db18ffe67c8d28059a4bfd6835f053fd48a6c12a21ad385df2aabf84ab87e60"
sha256 cellar: :any, arm64_big_sur: "8178a93f509e725ba63e318059851183ed8d599c6a9eda6a1918258f63400ab5"
sha256 cellar: :any, ventura: "00c541af823af303db5f25af6eed62ed43410b6f0a8d5459b72dfc33eef408a2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ventura bottles will fail to build, hence, deprecated. See below.

@carlocab carlocab added the ready to merge PR can be merged once CI is green label Jun 15, 2023
Also:

- deprecate, because it vendors an ancient version of folly that no
  longer works with newer versions of libc++. See facebook/folly#1867.
- remove Ventura bottles, because they will fail to build.
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 15, 2023
@BrewTestBot BrewTestBot merged commit 90ed721 into Homebrew:icu4c-staging Jun 15, 2023
@carlocab carlocab deleted the clickhouse-odbc-icu4c-73.2 branch June 15, 2023 13:38
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-dependents Pass --skip-dependents to brew test-bot. formula deprecated Formula deprecated icu4c ICU use is a significant feature of the PR or issue outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants