Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse-cpp 2.4.0 #128575

Merged
merged 2 commits into from
Apr 19, 2023
Merged

clickhouse-cpp 2.4.0 #128575

merged 2 commits into from
Apr 19, 2023

Conversation

p-linnane
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
## Fixes
* fix bug in ColumnLowCardinality::Load (#270 by @den818)
* fix bug with load/save Array with empty arrays (#272 by @den818)
* Fix crash on invalid AST (#273 by @Enmk)
* Fix getaddrinfo error reporting (#278 by @nUl1)
* Fixed deprecation warning (#285 by @Enmk)

New features

  • timeout from seconds to milliseconds (#253 by @1261385937)
  • Support column type: map (#254, #257 by @den818)
  • Support geo column types (#258 by @den818)
  • New method ColumnTuple::At(). (#268 by @huyphams)
  • ColumnNulableT and wrap for LowCardinalityT (#269 by @den818)
  • Add connect timeout to socket (#277 by @nUl1)
  • Handle "Bool" columns (#279 by @ays7)
  • Added Query.onProfile and handling of Profile data (#298 by @Enmk)

New options (clickhouse::ClientOptions)

  • connection_connect_timeout - socket connect timeout, milliseconds
  • connection_recv_timeout - socket recv timeout, milliseconds
  • connection_send_timeout - socket send timeout, milliseconds

Other

  • Separate building static and shared libs (#219 by @Jihadist)
  • Update bench.cpp (#242 by @dabao085)
  • Update LICENSE (#276 by @blinkov)
  • Add options to use system abseil, lz4 and cityhash (#281 by @Jihadist)
  • Dependencies info (#286 by @Enmk)
  • Expand application tutorial (#293 by @rschu1ze)
  • Fix formatting in README.md (#294 by @rschu1ze)
  • Fixed gcc13 warnings (#296 by @ays7)
  • Minor: Deprecated LowCardinalitySerializationAdaptor (#300 by @Enmk)

CI/CD

  • Scheduling CI/CD runs on Monday midnight (#263 by @Enmk)
  • Explicitly using ubuntu-20.04 instead of ubuntu-latest (#264 by @Enmk)
  • Disabled system.query_logs-dependent unit-tests (#267 by @Enmk)
  • Don't run query id tests on non linux (#298 by @Enmk)
  • Fix Windows build (#299 by @Enmk)

New Contributors

Full Changelog: ClickHouse/clickhouse-cpp@v2.3.0...v2.4.0

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Apr 17, 2023
@chenrui333
Copy link
Member

/usr/bin/ld: /home/linuxbrew/.linuxbrew/Cellar/clickhouse-cpp/2.4.0/lib/libclickhouse-cpp-lib.a(sslsocket.cpp.o): in function `clickhouse::SSLSocketOutput::DoWrite(void const*, unsigned long)':
  sslsocket.cpp:(.text+0x7d4): undefined reference to `SSL_write'
  /usr/bin/ld: sslsocket.cpp:(.text+0x818): undefined reference to `SSL_get_error'
  /usr/bin/ld: /home/linuxbrew/.linuxbrew/Cellar/clickhouse-cpp/2.4.0/lib/libclickhouse-cpp-lib.a(sslsocket.cpp.o): in function `clickhouse::SSLSocketInput::DoRead(void*, unsigned long)':
  sslsocket.cpp:(.text+0x869): undefined reference to `SSL_read_ex'
  /usr/bin/ld: sslsocket.cpp:(.text+0x8b0): undefined reference to `SSL_get_error'
  /usr/bin/ld: /home/linuxbrew/.linuxbrew/Cellar/clickhouse-cpp/2.4.0/lib/libclickhouse-cpp-lib.a(sslsocket.cpp.o): in function `(anonymous namespace)::prepareSSLContext(clickhouse::SSLParams const&)':
  sslsocket.cpp:(.text+0x[92](https://github.com/Homebrew/homebrew-core/actions/runs/4723556491/jobs/8379778710?pr=128575#step:9:93)0): undefined reference to `TLS_client_method'

@chenrui333 chenrui333 added build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Apr 17, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Apr 19, 2023
@p-linnane
Copy link
Member Author

Thank you @ZhongRuoyu 🙏

@p-linnane p-linnane added ready to merge PR can be merged once CI is green autosquash Automatically squash pull request commits according to Homebrew style. and removed build failure CI fails while building the software automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Apr 19, 2023
Comment on lines +32 to +33
inreplace "CMakeLists.txt", "FIND_PACKAGE(cityhash REQUIRED)",
"FIND_LIBRARY(CITYHASH NAMES cityhash REQUIRED)"
inreplace "clickhouse/CMakeLists.txt", "cityhash::cityhash", "cityhash"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upstream this? Or has upstream forked cityhash to provide a CMake config file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream has written a simple CMake config file for cityhash: https://github.com/ClickHouse/clickhouse-cpp/blob/master/contrib/cityhash/cityhash/CMakeLists.txt.

But since cityhash does not provide any CMake modules, the setup with WITH_SYSTEM_CITYHASH=ON is basically broken. I will upstream a proper fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream has written a simple CMake config file for cityhash: https://github.com/ClickHouse/clickhouse-cpp/blob/master/contrib/cityhash/cityhash/CMakeLists.txt.

That's what I thought. This project likes to just fork all their dependencies.

chenrui333
chenrui333 previously approved these changes Apr 19, 2023
@github-actions
Copy link
Contributor

🤖 A scheduled task has requested bottles to be published to this PR.

p-linnane and others added 2 commits April 19, 2023 23:05
* clickhouse-cpp 2.4.0
* clickhouse-cpp: fix build
  Also:
  1. Add deps that would otherwise be vendored.
  2. Eliminate CMake usage in test.

Closes #128575.

Co-authored-by: Ruoyu Zhong <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: BrewTestBot <[email protected]>
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 19, 2023
@BrewTestBot BrewTestBot enabled auto-merge April 19, 2023 23:05
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 19, 2023
Merged via the queue into Homebrew:master with commit d2eca1c Apr 19, 2023
@p-linnane p-linnane deleted the bump-clickhouse-cpp-2.4.0 branch April 20, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants