Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node@14: migrate to [email protected] #117341

Closed
wants to merge 1 commit into from
Closed

node@14: migrate to [email protected] #117341

wants to merge 1 commit into from

Conversation

singingwolfboy
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added icu4c ICU use is a significant feature of the PR or issue legacy Relates to a versioned @ formula long build Set a long timeout for formula testing labels Dec 5, 2022
@chenrui333 chenrui333 added python-3.11-migration and removed long build Set a long timeout for formula testing labels Dec 5, 2022
@chenrui333
Copy link
Member

Failed to execute: /home/linuxbrew/.linuxbrew/opt/[email protected]/bin/python3.11

@chenrui333 chenrui333 added build failure CI fails while building the software linux Linux is specifically affected labels Dec 5, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Dec 26, 2022
@cho-m
Copy link
Member

cho-m commented Dec 31, 2022

This won't work. Python 3.11 build support wasn't backported. Also, runtime support wasn't backported for node-gyp.

#118733
nodejs/node#45231

@cho-m cho-m closed this Dec 31, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
@chenrui333 chenrui333 added the python Python use is a significant feature of the PR or issue label Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
build failure CI fails while building the software icu4c ICU use is a significant feature of the PR or issue legacy Relates to a versioned @ formula linux Linux is specifically affected outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.11-migration stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@singingwolfboy @chenrui333 @cho-m @BrewTestBot