Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nu: fix build on Apple Silicon #112070

Closed
wants to merge 1 commit into from
Closed

nu: fix build on Apple Silicon #112070

wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 30, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Sep 30, 2022
@BrewTestBot BrewTestBot added the no ARM bottle Formula has no ARM bottle label Sep 30, 2022
Comment on lines 47 to 52
# Don't hard code path to clang.
inreplace "tools/nuke", "/usr/bin/clang", ENV.cc
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this works as intended on macOS since it checks if path exists (https://github.com/programming-nu/nu/blob/v2.3.0/tools/nuke#L280)

It first checks clang is a path which fails. Then tries #{sdk}clang which fails. Finally, it sets gcc.

However, since gcc is an alias for clang on macOS, there is no actual impact, so is probably okay.

@cho-m cho-m marked this pull request as ready for review October 1, 2022 01:39
@cho-m cho-m added ready to merge PR can be merged once CI is green and removed do not merge labels Oct 1, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the nu-arm branch October 1, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. no ARM bottle Formula has no ARM bottle ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants