Skip to content

emscripten 3.1.23#111582

Closed
BrewTestBot wants to merge 6 commits intoHomebrew:masterfrom
BrewTestBot:bump-emscripten-3.1.23
Closed

emscripten 3.1.23#111582
BrewTestBot wants to merge 6 commits intoHomebrew:masterfrom
BrewTestBot:bump-emscripten-3.1.23

Conversation

@BrewTestBot
Copy link
Copy Markdown
Contributor

@BrewTestBot BrewTestBot commented Sep 24, 2022 •
edited by carlocab
Loading

Created by brew bump

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. java Java use is a significant feature of the PR or issue long build Set a long timeout for formula testing nodejs Node or npm use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue labels Sep 24, 2022
@carlocab carlocab mentioned this pull request Sep 24, 2022
Closed
@carlocab
Copy link
Copy Markdown
Member

carlocab commented Sep 24, 2022

I've aligned the LLVM build with the upstream configuration at https://chromium.googlesource.com/emscripten-releases/.

Also looking at using upstream's tool/install.py instead of

homebrew-core/Formula/emscripten.rb

Lines 81 to 84 in 44f9ecb

# All files from the repository are required as emscripten is a collection
# of scripts which need to be installed in the same layout as in the Git
# repository.
libexec.install buildpath.children

to avoid installing unnecessary files.

Finally, it might be good to update post_install to avoid overriding a ~/.emscripten if a user has one. See https://github.com/emscripten-core/emscripten/blob/main/docs/packaging.md. We probably also need to fix up NODE_JS and JAVA in .emscripten.

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Sep 24, 2022

We can't use tools/install.py, since it assume that we are building out of a Git repo. But everything else should be done.

carlocab
carlocab reviewed Sep 24, 2022
View reviewed changes
Formula/emscripten.rb Outdated
Copy link
Copy Markdown
Member

@carlocab carlocab Sep 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emcc --generate-config will error if this file exists, so let's skip the post_install and just warn in caveats if this file exists.

BrewTestBot and others added 6 commits September 25, 2022 15:17
@BrewTestBot @carlocab
emscripten 3.1.23
1b41218
@carlocab
emscripten: update resources
aaf51bc 
Also, update the LLVM build by:
1. Removing useless bits (e.g. `ENV.permit_arch_flags`)
2. Avoiding undesirable opportunistic linkage with other formulae
@carlocab
emscripten: align with upstream build configuration
26bc270 
This was taken from the upstream build at

    https://chromium.googlesource.com/emscripten-releases/
@carlocab
emscripten: clean up post_install
4a97da4 
Also, improve the definition of `emscripts`.
@carlocab
emscripten: remove outdated comment.
c8bf240 
`emscripten` will be removed from the allowlist in #111602.
@carlocab
emscripten: more cleanup
2e9864f 
- remove the unnecessary `test/third_party` directory. This saves about
  53M of space.
- call `ENV.remove_macosxsdk` in the `test` block.
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-test-bot-fail-fast Pass --fail-fast to brew test-bot. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Sep 25, 2022
@BrewTestBot
Copy link
Copy Markdown
Contributor Author

BrewTestBot commented Sep 25, 2022

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2022
@p-linnane p-linnane deleted the bump-emscripten-3.1.23 branch February 24, 2024 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlocab carlocab carlocab approved these changes

Assignees

No one assigned

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-test-bot-fail-fast Pass --fail-fast to brew test-bot. java Java use is a significant feature of the PR or issue long build Set a long timeout for formula testing nodejs Node or npm use is a significant feature of the PR or issue outdated PR was locked due to age python Python use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BrewTestBot @carlocab