Skip to content

trino 396#111295

Closed
cho-m wants to merge 1 commit intoHomebrew:masterfrom
cho-m:bump-trino-396
Closed

trino 396#111295
cho-m wants to merge 1 commit intoHomebrew:masterfrom
cho-m:bump-trino-396

Conversation

@cho-m
Copy link
Copy Markdown
Member

@cho-m cho-m commented Sep 21, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

For JDK 19 #111280

@BrewTestBot BrewTestBot added java Java use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue labels Sep 21, 2022
@cho-m cho-m mentioned this pull request Sep 21, 2022
@cho-m
Copy link
Copy Markdown
Member Author

cho-m commented Sep 21, 2022

Locally, bottle is ~700M:

exa -al trino--396.arm64_monterey.bottle.tar.gz
.rw-r--r-- 703M cho-m 20 Sep 19:21 trino--396.arm64_monterey.bottle.tar.gz

vs existing bottle size of 1.9G

exa -al 7761e292358f6208fe44f158f1e035c816271c4b55a14957456e8c29d86b0a37--trino--375.arm64_monterey.bottle.tar.gz
.rw-r--r-- 1.9G cho-m 29 Mar 06:46 7761e292358f6208fe44f158f1e035c816271c4b55a14957456e8c29d86b0a37--trino--375.arm64_monterey.bottle.tar.gz

  bottle do
    sha256 cellar: :any_skip_relocation, arm64_monterey: "0bc7711c41483689fed4aeb499293b630295a25b0b0dc83cb170112b784103ac"
  end
  bottle do
    sha256 cellar: :any_skip_relocation, x86_64_linux: "0bc7711c41483689fed4aeb499293b630295a25b0b0dc83cb170112b784103ac"
  end

@cho-m cho-m added the ready to merge PR can be merged once CI is green label Sep 21, 2022
# size from MBs to GBs. Remove once Homebrew is able to preserve hardlinks.
# Ref: https://github.com/Homebrew/brew/pull/13154
libexec.mkpath
system "tar", "-C", libexec.to_s, "--strip-components", "1", "-xzf", "trino-server-#{version}.tar.gz"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

It would be good to handle hard links properly though; I'm pretty sure other formulae will benefit too.

If we don't know how to do that, we could maybe consider just replacing hard links with soft links when bottling.

@BrewTestBot
Copy link
Copy Markdown
Contributor

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the bump-trino-396 branch September 21, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Java use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants