Closed
Conversation
Closed
Member
Author
|
Locally, bottle is ~700M: ❯ exa -al trino--396.arm64_monterey.bottle.tar.gz
.rw-r--r-- 703M cho-m 20 Sep 19:21 trino--396.arm64_monterey.bottle.tar.gzvs existing bottle size of 1.9G ❯ exa -al 7761e292358f6208fe44f158f1e035c816271c4b55a14957456e8c29d86b0a37--trino--375.arm64_monterey.bottle.tar.gz
.rw-r--r-- 1.9G cho-m 29 Mar 06:46 7761e292358f6208fe44f158f1e035c816271c4b55a14957456e8c29d86b0a37--trino--375.arm64_monterey.bottle.tar.gz |
carlocab
reviewed
Sep 21, 2022
| # size from MBs to GBs. Remove once Homebrew is able to preserve hardlinks. | ||
| # Ref: https://github.com/Homebrew/brew/pull/13154 | ||
| libexec.mkpath | ||
| system "tar", "-C", libexec.to_s, "--strip-components", "1", "-xzf", "trino-server-#{version}.tar.gz" |
Member
There was a problem hiding this comment.
Great idea!
It would be good to handle hard links properly though; I'm pretty sure other formulae will benefit too.
If we don't know how to do that, we could maybe consider just replacing hard links with soft links when bottling.
carlocab
approved these changes
Sep 21, 2022
Contributor
|
🤖 A scheduled task has triggered a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?For JDK 19 #111280