openjdk: Ensure rpath for libraries includes server/lib

[deejgregor]

Also:
openjdk@11: Ensure rpath for libraries includes server/lib
openjdk@17: Ensure rpath for libraries includes server/lib

I couldn't build openjdk@8 because I have too new of a version of Xcode installed, so I did not include a change for that formula.

Closes: #111068

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[deejgregor]

Question: I'm not sure if this needs a new revision as mentioned here: https://github.com/Homebrew/homebrew-core/blob/HEAD/CONTRIBUTING.md#to-contribute-a-fix-to-the-foo-formula

[carlocab]

Yes, let's bump the revision.

You can also remove the ignore_missing call inside the on_linux blocks. Those will be fixed by the -rpath configuration.

[Bo98]

I'd personally have a ldflags array that we join(" ") so we don't have this duplication.

[carlocab]

Yea, I considered that too. Let's do that.

[carlocab]

Linkage still broken on Linux. The build may not be respecting --with-extra-ldflags.

[carlocab]

Here's the RPATH in libmanagement.so in the Linux bottle for openjdk:

$ORIGIN
/homebrew/linuxbrew/.linuxbrew/Cellar/openjdk/18.0.2.1_1/lib
/homebrew/linuxbrew/.linuxbrew/opt/gcc/lib/gcc/current
/homebrew/linuxbrew/.linuxbrew/opt/alsa-lib/lib
/homebrew/linuxbrew/.linuxbrew/opt/openssl@1.1/lib
/homebrew/linuxbrew/.linuxbrew/opt/bison/lib
/homebrew/linuxbrew/.linuxbrew/opt/krb5/lib
/homebrew/linuxbrew/.linuxbrew/opt/zlib/lib
/homebrew/linuxbrew/.linuxbrew/opt/gmp/lib
/homebrew/linuxbrew/.linuxbrew/opt/bdw-gc/lib
/homebrew/linuxbrew/.linuxbrew/opt/libtool/lib
/homebrew/linuxbrew/.linuxbrew/opt/libunistring/lib
/homebrew/linuxbrew/.linuxbrew/opt/ncurses/lib
/homebrew/linuxbrew/.linuxbrew/opt/readline/lib
/homebrew/linuxbrew/.linuxbrew/opt/libffi/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxcrypt/lib
/homebrew/linuxbrew/.linuxbrew/opt/guile/lib
/homebrew/linuxbrew/.linuxbrew/opt/icu4c/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxml2/lib
/homebrew/linuxbrew/.linuxbrew/opt/gettext/lib
/homebrew/linuxbrew/.linuxbrew/opt/libidn2/lib
/homebrew/linuxbrew/.linuxbrew/opt/libtasn1/lib
/homebrew/linuxbrew/.linuxbrew/opt/nettle/lib
/homebrew/linuxbrew/.linuxbrew/opt/p11-kit/lib
/homebrew/linuxbrew/.linuxbrew/opt/libevent/lib
/homebrew/linuxbrew/.linuxbrew/opt/libnghttp2/lib
/homebrew/linuxbrew/.linuxbrew/opt/expat/lib
/homebrew/linuxbrew/.linuxbrew/opt/unbound/lib
/homebrew/linuxbrew/.linuxbrew/opt/gnutls/lib
/homebrew/linuxbrew/.linuxbrew/opt/cups/lib
/homebrew/linuxbrew/.linuxbrew/opt/libpng/lib
/homebrew/linuxbrew/.linuxbrew/opt/bzip2/lib
/homebrew/linuxbrew/.linuxbrew/opt/freetype/lib
/homebrew/linuxbrew/.linuxbrew/opt/util-linux/lib
/homebrew/linuxbrew/.linuxbrew/opt/fontconfig/lib
/homebrew/linuxbrew/.linuxbrew/opt/isl/lib
/homebrew/linuxbrew/.linuxbrew/opt/mpfr/lib
/homebrew/linuxbrew/.linuxbrew/opt/libmpc/lib
/homebrew/linuxbrew/.linuxbrew/opt/lz4/lib
/homebrew/linuxbrew/.linuxbrew/opt/xz/lib
/homebrew/linuxbrew/.linuxbrew/opt/zstd/lib
/homebrew/linuxbrew/.linuxbrew/opt/binutils/lib
/homebrew/linuxbrew/.linuxbrew/opt/gcc/lib
/homebrew/linuxbrew/.linuxbrew/opt/libpthread-stubs/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxau/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxdmcp/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxcb/lib
/homebrew/linuxbrew/.linuxbrew/opt/libx11/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxext/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxrender/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxrandr/lib
/homebrew/linuxbrew/.linuxbrew/opt/libice/lib
/homebrew/linuxbrew/.linuxbrew/opt/libsm/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxt/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxfixes/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxi/lib
/homebrew/linuxbrew/.linuxbrew/opt/libxtst/lib
/homebrew/linuxbrew/.linuxbrew/lib

This is missing $ORIGIN/server, which means our flag isn't being respected.

[carlocab]

Ok, not sure what's going on with Linux, so I'll keep the ignore_missing_libraries for now. CC @Homebrew/linux in case anyone has any ideas.

[carlocab]

Dependent tests succeeded, but openjdk@11 failed to build on Linux. To save CI time let's re-run but skip dependents.

[carlocab]

Thanks!

[BrewTestBot]

@carlocab has triggered a merge.

[danielnachun]

The ignore_missing_libraries is needed because OpenJDK finds these libraries using dlopen at runtime. So to the best of my knowledge this is expected and not a problem.

[carlocab]

ignore_missing_libraries is something we carry around for essentially just OpenJDK, though, and it wouldn't be needed if we just had $ORIGIN/server in RPATH. It would be good to be able to get rid of it.