Skip to content

Commit

Permalink
watchman: migrate to [email protected]
Browse files Browse the repository at this point in the history 
Closes #62458.

Signed-off-by: Rylan Polster <[email protected]>
Signed-off-by: BrewTestBot <[email protected]>
  • Loading branch information
@fxcoudert @BrewTestBot
fxcoudert authored and BrewTestBot committed Oct 8, 2020
1 parent 6d3f9b9 commit 05d79b2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Formula/watchman.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ class Watchman < Formula
desc "Watch files and take action when they change"
homepage "https://github.com/facebook/watchman"
license "Apache-2.0"
revision 4
revision 5
head "https://github.com/facebook/watchman.git"

stable do
Expand Down Expand Up @@ -35,7 +35,7 @@ class Watchman < Formula
depends_on "pkg-config" => :build
depends_on "[email protected]"
depends_on "pcre"
depends_on "python@3.8"
depends_on "python@3.9"

def install
system "./autogen.sh"
Expand All @@ -49,7 +49,7 @@ def install
system "make", "install"

# Homebrew specific python application installation
python3 = Formula["python@3.8"].opt_bin/"python3"
python3 = Formula["python@3.9"].opt_bin/"python3"
xy = Language::Python.major_minor_version python3
ENV.prepend_create_path "PYTHONPATH", libexec/"lib/python#{xy}/site-packages"
cd "python" do
Expand Down

4 comments on commit 05d79b2

@shytikov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it really that necessary? Now I have two pythons installed side-by-side one is 3.8.5 and another is 3.9.0 because of that...

@SMillerDev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, seeing how Homebrew is an evergreen package manager. Python 3.9 is released so we'll be moving over as many formula as we can.

@shytikov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a ruby guy (python guy actually), but maybe I can also help? Is there any list of formulas needs to be migrated?

@SMillerDev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#62201

Please sign in to comment.