Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed webp-quicklook to webpquicklook #7908

Merged
merged 1 commit into from
Dec 11, 2014
Merged

renamed webp-quicklook to webpquicklook #7908

merged 1 commit into from
Dec 11, 2014

Conversation

vitorgalvao
Copy link
Member

As stated by @rolandwalker in #3344, we should:

try to avoid the case where a Cask name differs only by the placement of a hyphen.

However, it seems we forgot to change these (the other being emin-webpquicklook.rb), even though they were part of the rule’s mention. This PR addresses that.

@rolandwalker
Copy link
Contributor

What I was speaking to in that particular case was that webp-quicklook.rb and webpquicklook.rb differed only by a hyphen which seems counter to usability. We resolved it by prepending emin-.

But I have no problem with this change if it makes sense to you. Really only app Casks and font Casks have defined tokens. Everything else is still unconquered and irregular. Though we should get to them at some point, for the sake of "upgrade".

vitorgalvao added a commit that referenced this pull request Dec 11, 2014
renamed webp-quicklook to webpquicklook
@vitorgalvao vitorgalvao merged commit 95f9a6c into Homebrew:master Dec 11, 2014
@vitorgalvao vitorgalvao deleted the webpquicklook-rename branch December 11, 2014 04:02
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants