Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Voila screengrabber #5902

Closed
wants to merge 2 commits into from
Closed

Add Voila screengrabber #5902

wants to merge 2 commits into from

Conversation

treyharris
Copy link
Contributor

This application is unusual: it comes in an dmg containing the naked
app rather than a package, but yet it insists on being run directly
from its install location--no symlinks.

I wasn't able to find another example of such a thing in an existing
cask, so I made a stab at doing it manually.

I just checked and it will work via a Mac alias file, but I don't
know how to create one of those short of calling osascript.

This application is unusual: it comes in an dmg containing the naked
app rather than a package, but yet it insists on being run directly
from its install location--no symlinks.

I wasn't able to find another example of such a thing in an existing
cask, so I made a stab at doing it manually.

I just checked and it _will_ work via a Mac alias file, but I don't
know how to create one of those short of calling osascript.
@rolandwalker
Copy link
Contributor

See related comments in #6001.

Two small points about this Cask specifically:

  • having the uninstall stanza available for non-pkg Casks is a quasi-undocumented new feature which is supposed to be made official in a few days. It will silently fail for users of older versions.
    • ditto will work better than cp

I'm not opposed to hackery inside the Casks. One might say that this entire project is a hack to hide various install details behind a single interface.

So, if you are impatient with the outlook in #6001, my opinion is that we can merge this on the basis that it "works for now". However,

  • I'd prefer to pause until the official waiting period is over (8 Sep) as you have used a new feature.
  • If any of the other maintainers object to the complexity, I'd be inclined to defer to their veto.

Many thanks for your contributions to this project.

@vitorgalvao
Copy link
Member

This is so old, the cask format is not even this one, anymore, and other things needs updating as well. If you’re still interested in adding, please resubmit, @treyharris.

@miccal miccal removed the cask label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants