Skip to content

Conversation

@antoni
Copy link
Contributor

@antoni antoni commented Jan 11, 2019

There are only RC versions available and this is the latest one, so I believe this qualifies as a documented exception.
Contents of this cask are based on java.rb cask, as GraalVM is:

a standalone Java Development Kit that you can use for executing Java or JVM-based applications (...) (source)

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

@vitorgalvao
Copy link
Contributor

Quite frankly, I’m tired of all the JVM/JDK versions, every one with their own idiosyncrasies, because one is more stable if you clipped your nails last Thursday, but the other is 200ms faster if your second cousin has a green dress woven with an open-source loom.

These casks are high maintenance. They break all the time from upstream changes; versions are never consistent; multiple versions need to be supported; and whatnot. We recently tried to make sense of it all in terms of inclusion, but the person in charge of it has since left the project and can’t really be pinged back.

There’s been talks of moving all java-development casks elsewhere, and I think this is as good a time as any. I’m going to block inclusion of this and open an issue for discussion.

@vitorgalvao
Copy link
Contributor

#57387

@antoni antoni closed this Jan 16, 2019
@lock lock bot added the outdated label Feb 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants