Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename KeyRemap4MacBook to Karabiner #5282

Merged
merged 1 commit into from
Jul 10, 2014
Merged

Rename KeyRemap4MacBook to Karabiner #5282

merged 1 commit into from
Jul 10, 2014

Conversation

rayne-b
Copy link

@rayne-b rayne-b commented Jul 10, 2014

KeyRemap4MacBook got renamed to Karabiner, so I removed the old cask. I'm not sure if there is a protocol for allowing users to seamlessly upgrade without having to have explicit knowledge of the name change, but if there is, let me know and I will fix up this PR.

@vitorgalvao
Copy link
Contributor

We don’t yet have an upgrade command, so users would have to do it manually anyway.

Merged.

vitorgalvao added a commit that referenced this pull request Jul 10, 2014
Rename KeyRemap4MacBook to Karabiner
@vitorgalvao vitorgalvao merged commit fdd6ef2 into Homebrew:master Jul 10, 2014
@rolandwalker rolandwalker mentioned this pull request Jul 10, 2014
@radeksimko
Copy link
Contributor

I'm not sure about this slightly disruptive way of upgrade.

Imagine this situation:

  1. brew cask install keyremap4macbook
  2. apply this pull request
  3. brew cask uninstall keyremap4macbook
  4. it silently just removes the installation folder somewhere, but the whole package remains installed and functional

I'd rather leave it there for a while with a meaningful caveats (guide how to install the new version).

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants