Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sketch Up (version 8) Cask #452

Merged
merged 2 commits into from
Jul 7, 2013
Merged

Add Sketch Up (version 8) Cask #452

merged 2 commits into from
Jul 7, 2013

Conversation

acollign
Copy link
Contributor

@acollign acollign commented Jun 3, 2013

The easy, fun, and free way to draw in 3D

  • Model anything in 3D.
  • Share and download models from SketchUp’s 3D Warehouse.
  • SketchUp Make is not licensed for commercial work.

@vitorgalvao
Copy link
Member

I’m finding a discrepancy. When I download from that url, I don’t get an installer, I get a .dmg with three .app files. Was there some recent update tat changed that?

@acollign
Copy link
Contributor Author

I guess they released a new dmg. I'll check that asap. Thanks for the info

@acollign
Copy link
Contributor Author

acollign commented Jul 7, 2013

Hi @vitorgalvao,

I just pushed a commit fixing the issue you have reported last month. Sketch Up 2013 was released between the creation of the pull request and your check, thus explain why the test you have made failed.

The new DMG requests users to agree on the license causing cask to prompt "Agree Y/N?". Users can agree by entering yes but that means users agree without reading the license...

Have you already dealt with such a situation ?

@vitorgalvao
Copy link
Member

Yes, that’s standard behaviour, although we could reconsider that, since technically it is feasible. However, if a user agrees without reading just by seeing the prompt, showing the agreement would’t necessarily change that.

For now, everything looks good, so I’m going to merge this. Thank you.

vitorgalvao added a commit that referenced this pull request Jul 7, 2013
Add Sketch Up (version 8) Cask
@vitorgalvao vitorgalvao merged commit f173293 into Homebrew:master Jul 7, 2013
@acollign acollign deleted the sketchup branch July 7, 2013 13:39
@acollign
Copy link
Contributor Author

acollign commented Jul 7, 2013

However, if a user agrees without reading just by seeing the prompt, showing the agreement would’t necessarily change that.

I do agree with you. I was more thinking about legal requirements.

I’m going to merge this. Thank you.

You're welcome. I hope to create a few others pr soon.

@vitorgalvao
Copy link
Member

The feature was already there before I even heard of the project, so I have no idea if this was already discussed or not. That’s a very good point, though, so I’ll try to figure it out. I’m not sure if we can suppress the agreement or not, since the prompt is an indicator it exists, and that you can check it manually, if you so wish.

@acollign
Copy link
Contributor Author

I wouldn't suppress the agreement request but I think we need to provide users with a way of reading the license they are going to agree on. If you think this discussion deserves to be discussed with a wider audience, I would be glad to raise the question on a specific issue.

@phinze
Copy link
Contributor

phinze commented Jul 10, 2013

I've got some opinions, (Opinions I tell you! 😀) so I'll open up a separate issue to track that discussion.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants