-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sketch Up (version 8) Cask #452
Conversation
I’m finding a discrepancy. When I download from that url, I don’t get an installer, I get a .dmg with three .app files. Was there some recent update tat changed that? |
I guess they released a new dmg. I'll check that asap. Thanks for the info |
Hi @vitorgalvao, I just pushed a commit fixing the issue you have reported last month. Sketch Up 2013 was released between the creation of the pull request and your check, thus explain why the test you have made failed. The new DMG requests users to agree on the license causing cask to prompt "Agree Y/N?". Users can agree by entering yes but that means users agree without reading the license... Have you already dealt with such a situation ? |
Yes, that’s standard behaviour, although we could reconsider that, since technically it is feasible. However, if a user agrees without reading just by seeing the prompt, showing the agreement would’t necessarily change that. For now, everything looks good, so I’m going to merge this. Thank you. |
Add Sketch Up (version 8) Cask
I do agree with you. I was more thinking about legal requirements.
You're welcome. I hope to create a few others pr soon. |
The feature was already there before I even heard of the project, so I have no idea if this was already discussed or not. That’s a very good point, though, so I’ll try to figure it out. I’m not sure if we can suppress the agreement or not, since the prompt is an indicator it exists, and that you can check it manually, if you so wish. |
I wouldn't suppress the agreement request but I think we need to provide users with a way of reading the license they are going to agree on. If you think this discussion deserves to be discussed with a wider audience, I would be glad to raise the question on a specific issue. |
I've got some opinions, (Opinions I tell you! 😀) so I'll open up a separate issue to track that discussion. |
The easy, fun, and free way to draw in 3D