-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create eclipse-jee.rb - a cask for Eclipse for Java Enterprise edition #4445
Conversation
add a cask for eclipse-jee (Eclipse Java Enterprise Edition).
Thanks for the new cask. I don't see version specified in any of the two URLs, so I'd rather use Also I'm not a heavy user of Eclipse, the "Java EE" in the name means it requires EE version to run the IDE or it allows easier development of apps in EE version? I managed to launch it with Java SE 8 (aint's saying it means it's supported). |
@radeksimko, thanks for digging up this dropped PR! 30 days is way too long for a response time. All Java-related Casks seem to be slowed down; we need to either develop our knowledge, or add to our team. We shouldn't advertise But it takes much longer for the backend code to percolate out. Assuming things go well, it will be probably two months from now before we document |
It does not require Java EE, but it provides plugins that helps developing JAVA EE apps. |
That's good situation then. I reckon there's still Java dependency, but that can be solved altogether with other Java-dependent packages in #4885 As the download URL does not include any particular version, could you just change After these small changes, it's good to go. |
fix cask as requested in pull #4445
As the x86 and x86_64 versions are different files I left that on the conditional blocks. |
I just started a new job and I will not be able to maintain this cask. Only merge it if else can maintain it. I am very sorry for any wasted time but I just got the news. |
@jmarrero Submitting a cask in no way brings an obligation to maintain it, you have nothing to worry on that front. Could you please squash your commits, though? @radeksimko Since you’ve been following this submission more closely, could it be merged after the squash? |
Squashed the previous commits. @vitorgalvao thanks for clarifying. Thank you for all the great work you guys do with cask :) If I can contribute in the future I will do so. Continue the great work 👍 |
Sorry to bother you with this, but I still see two commits (create & update) @jmarrero |
You both have more important things to do right now than worry about such a small change, so I’ll merge this in #5115, squashed, and with the stanzas in the preferred order. All credit still goes to @jmarrero — it’s still your commit in the PR, with the appropriate changes. Thank you for the contribution and patience, we can finally close this. |
add a cask for eclipse-jee (Eclipse Java Enterprise Edition).