Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: drop version numbers from end of Cask names #3285

Merged

Conversation

rolandwalker
Copy link
Contributor

Following up on #2659, #3175, and #3255, further steps toward an algorithmic
derivation of Canonical Name from App Name.

Rationale (just as before)

Enforcing this rule would affect 4 current Casks: gpower3.rb, marked2.rb, airmail-beta.rb, logmein-ignition-beta.rb

Pinging @vitorgalvao. Here is the next round of proposed naming rules.

I can only find two exceptions where a trailing number differentiates a product from different vendors: iterm2 and pgadmin3.

Exception: when a number is not an incremental release counter, but a
differentiator for a different product from a different vendor: [iterm2.rb](../Casks/iterm2.rb).
* If the version number is arranged to occur in the middle of the App name,
it should also be removed. Example: [IntelliJ IDEA 13 CE.app](../Casks/iterm2.rb).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 156, shouldn't the example point to the IntelliJ cask, not the iTerm cask?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vitorgalvao
Copy link
Member

Thumbs up here as well. I agree.

rolandwalker added a commit that referenced this pull request Mar 1, 2014
doc: drop version numbers from end of Cask names
@rolandwalker rolandwalker merged commit 83b8431 into Homebrew:master Mar 1, 2014
@rolandwalker rolandwalker deleted the doc_cask_name_drop_version branch March 1, 2014 11:48
@rolandwalker rolandwalker mentioned this pull request Jun 4, 2014
87 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants