Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsidian Menu Bar for 10.9 Mavericks cask #2750

Closed
wants to merge 1 commit into from
Closed

Obsidian Menu Bar for 10.9 Mavericks cask #2750

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 4, 2014

Followed https://github.com/phinze/homebrew-cask/blob/master/Casks/obsidian-menu-bar-mountain-lion.rb as an example.

  • Not sure if it's obvious or not to Log Out & Log In...
  • Not sure if this is a good use of caveats
  • Not sure if running the install script is good behavior

I'm new to contributing, please help me help you

@rolandwalker
Copy link
Contributor

Hi! And Thanks!

I've looked at this, but I think it will need several changes to go in. We definitely don't use after_install to start a GUI app -- our mission is to help users avoid the GUI completely.

Are you saying the user does need to log in/out for this package to work? If so, you can express that with caveats:

caveats do
  logout
end

Will look further at this tomorrow.

@ghost
Copy link
Author

ghost commented Feb 9, 2014

https://twitter.com/maxrudberg/status/432130608517881856
In talks with the developer about a prompt-less install script, will re-commit soon. 👍

@rolandwalker
Copy link
Contributor

That's great, because I took a look and this one is really complex -- quite a bit to tackle for your first submission, but I will also try to support you.

@jedahan
Copy link
Contributor

jedahan commented May 1, 2014

+1 for this

@ghost
Copy link
Author

ghost commented May 22, 2014

Help me convince the dev? https://twitter.com/maxrudberg/status/432130608517881856

@nanoxd
Copy link
Contributor

nanoxd commented Jun 11, 2014

@tylermolamphy Any luck convincing the dev?

@vitorgalvao
Copy link
Member

This has been moved to the boneyard a while back.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants