Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cask for weka. #2326

Merged
merged 1 commit into from
Jan 6, 2014
Merged

Adding cask for weka. #2326

merged 1 commit into from
Jan 6, 2014

Conversation

leoromanovsky
Copy link
Contributor

Weka is a popular tool for machine learning used by researchers. This cask starts at version 3.6.10.

@vitorgalvao
Copy link
Member

Seeing as url doesn’t seem to point to a specific version, this cask should use version 'latest' and no_checksum. See an example.

@leoromanovsky
Copy link
Contributor Author

@vitorgalvao From the documentation on URL suggestions, I thought that "latest" was the preferred URL to use. My personal preference would be to explicitly call out a certain version. What do you think of changing it to that?

@vitorgalvao
Copy link
Member

The value of having it one way or another is an open discussion. In the meantime, however, consistency is more important than the preferences of any individual user. If you feel like having versions in every cask is the right solution, please give us your reasoning on the the linked issue.

If we change that policy, than we’ll do it for every cask, but for now, for this to be accepted, please follow the guidelines.

@leoromanovsky
Copy link
Contributor Author

@vitorgalvao ok thanks, got it. I've changed it to the latest version with no checksums.

If you notice, for this particular project, the maintainers have given their app a poor name and added the version number to the file package 👎

@vitorgalvao
Copy link
Member

I see. Maybe in that case you’d prefer to use the other kind of url (http://downloads.sourceforge.net/sourceforge/weka/weka-3-6-10-oracle-jvm.dmg). That’d allow you to set the version, like you had before, and since the app has the version in its name (which means the cask will break anyway, when the application is updated), it’d be a safer way to maintain the cask.

@leoromanovsky
Copy link
Contributor Author

Travis CI doesn't like that this is throwing a warning.

➜  phinze-cask git:(weka) ✗ brew cask audit weka --download
==> Downloading http://sourceforge.net/projects/weka/files/weka-3-6-osx/3.6.10/wek
######################################################################## 100.0%
audit for weka: warning
 - SourceForge URL format incorrect. See https://github.com/phinze/homebrew-cask/blob/master/CONTRIBUTING.md#sourceforge-urls

@vitorgalvao
Copy link
Member

Use the link I posted in the previous comment — http://downloads.sourceforge.net/sourceforge/weka/weka-3-6-10-oracle-jvm.dmg, it should work.

Weka is a popular tool for machine learning used by researchers. This cask starts at version 3.6.10.
@leoromanovsky
Copy link
Contributor Author

Thanks for your help. Adding more casks in the future will be straightforward for me.

@vitorgalvao
Copy link
Member

No problem. Thank you for being so quick with the changes. Merged.

vitorgalvao added a commit that referenced this pull request Jan 6, 2014
@vitorgalvao vitorgalvao merged commit 50356f6 into Homebrew:master Jan 6, 2014
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants