Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitkraken 1.0.0 #20277

Merged
merged 1 commit into from
Apr 4, 2016
Merged

gitkraken 1.0.0 #20277

merged 1 commit into from
Apr 4, 2016

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Apr 4, 2016

Changes to a cask

Editing an existing cask

  • Commit message includes cask’s name (and new version, if applicable).
  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} left no offenses.

version '0.9.2'
sha256 '810654fcf0813552f4cd7ee6032440f1e7072d3f2bb2442c3d02e484fed2d345'
version '1.0.0'
sha256 '3f93b84ea57d58396d759f9882be0275fdf370baba457e463edb5c40b060caad'

url "http://release.gitkraken.com/darwin/v#{version}.zip"
appcast 'https://release.gitkraken.com/darwin/RELEASES',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the :checkpoint value in appcast is required. You can find it with curl --silent --compressed "{{appcast_url}}" | sed 's|<pubDate>[^<]*</pubDate>||g' | shasum --algorithm 256 | awk '{ print $1 }'.

Alternatively, you may wish to use cask-repair. It can at once update the cask’s version (according to what you give it) taking care of updating both the cask’s sha256 and the appcast’s :checkpoint, while still giving you the chance to perform other manual fixes.

You can easily install it with brew install vitorgalvao/tiny-scripts/cask-repair. cask-repair --help will show you some options, but as a whole the script will guide you through the update process.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. It would help for this check to be added to brew cask audit. Could cask-repair be added to homebrew-cask?

@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label Apr 4, 2016
@vitorgalvao
Copy link
Member

It would help for this check to be added to brew cask audit

It would. We’re in dire need of a PR.

Could cask-repair be added to homebrew-cask?

In what sense?

@vitorgalvao vitorgalvao merged commit b583f57 into Homebrew:master Apr 4, 2016
@sjackman sjackman deleted the gitkraken-1.0.0 branch April 5, 2016 00:47
@sjackman
Copy link
Member Author

sjackman commented Apr 5, 2016

Thanks for merging. Sorry that I'm not able to contribute the time to make the PR. =(

Could cask-repair be added to homebrew-cask?

In what sense?

Add a brew cask repair command.

@vitorgalvao
Copy link
Member

I thought about that before, but cask-repair is made in bash, and there’s a lot that needs to be done in homebrew-cask itself. It’s breaking everywhere, and there’s plenty to fix. I’d rather we fix those problems first.

@adidalal adidalal removed awaiting maintainer feedback Issue needs response from a maintainer. awaiting user reply Issue needs response from a user. labels Apr 12, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants