tableau 2024.3.1 and update livecheck strategy

[okkymabruri]

change:

• updated tableau 2024.3.1 released on November 21, 2024
• modified livecheck strategy url to https://www.tableau.com/app/discover/desktop

---

• The submission is for a stable version or documented exception.
• brew audit --cask --online tableau is error-free.
• brew style --fix tableau reports no offenses.

---

[samford]

The discussion in the open tableau-prep PR applies here. If the XML file isn't being kept up to date (neither 2024.3.0 nor 2024.3.1 have been present so far), then we will need to check another source of version information. As mentioned in the linked comment, I would suggest checking the Releases page (the livecheck block in this PR relies on the existence of the "Update to 2024.3.1 Now" notice at the bottom of the page, which may not always be present). If we decide to check a different source (even if temporarily), I already have a livecheck block worked up to check the Releases page and can push it here. Granted, I'm not sure if checking the Releases page will return a 403 response on CI as well (it works fine locally).

[okkymabruri]

Thank you for your feedback and detailed explanation, @samford.

I didn’t notice your earlier discussion about the XML been using for the livecheck not being up to date

The #191077 (review) applies here. If the XML file isn't being kept up to date (neither 2024.3.0 nor 2024.3.1 have been present so far), then we will need to check another source of version information...

Since the highest version on the Desktop releases page is 2024.3, but the XML file only goes up to 2024.2.4, relying on the XML file might prevent users from accessing the latest version. As far as I know, the latest version fixes “No such column” and authentication issues.

I support updating the livecheck block to reference the releases page instead of the XML file.

... I would suggest checking the Releases page (the livecheck block in this PR relies on the existence of the "Update to 2024.3.1 Now" notice at the bottom of the page, which may not always be present). If we decide to check a different source (even if temporarily), I already have a livecheck block worked up to check the Releases page and can push it here. Granted, I'm not sure if checking the Releases page will return a 403 response on CI as well (it works fine locally).

I agree, checking the Releases page (the livecheck block is a better approach. Relying on the “Update to 2024.3.1 Now” notice on the Desktop page might be unreliable if that notice isn’t always present. or Releases page: releases/desktop/latest could be another option.

for this PR, Do you think reverting to the previous livecheck for now would be a good option?

[samford]

Do you think reverting to the previous livecheck for now would be a good option?

We have an audit that checks to ensure that the cask version and the version from livecheck are the same, so this PR would fail CI for that reason if we used the existing livecheck block (that checks the XML file).

Let me push the livecheck block change (updating it to check the Releases page) and see if that works on CI or not.

[samford]

As expected, checking the Releases page also fails in the CI environment. We don't autobump this cask, so having a livecheck block that only works locally but correctly returns the latest release is better than having one that works on CI but doesn't return the latest release. It's not ideal but we would have to skip livecheck on CI either way, so the former will at least ensure that we can get up to date version information when running brew livecheck locally.

I've added an explanatory comment before the livecheck block, to remind us to manually check the XML file as new versions are released and switch back to that check if/when upstream starts reliably updating the file to include the newest versions.

I've re-run this with the ci-skip-livecheck label, so it should pass CI this time and we can move forward with this version bump if our cask maintainers agree with this approach. I'll update the open tableau-public PR and create version bump PRs for the other tableau-* casks, as they reference the tableau livecheck block.