Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[font] Update Nerd Font casks to v3.3.0 #192468

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

Finii
Copy link
Contributor

@Finii Finii commented Nov 18, 2024

This PR has been automatically created by a Nerd Font release workflow.
The individual casks where not checked, but are created by a (the same as before) script.
Compare Homebrew/homebrew-cask-fonts#9236

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@Finii
Copy link
Contributor Author

Finii commented Nov 18, 2024

Hmm, one of the problems I encountered was that my Cask has been renamed, obviously. Which our CI script did not know, obviously.

Whatever, changed that in our CI.

commit 87e1c59

author:     Markus Reiter <[email protected]>
AuthorDate: Sat Aug 10 19:46:24 2024 +0200
Commit:     Patrick Linnane <[email protected]>
CommitDate: Fri Aug 23 10:07:30 2024 -0700

    Allow `+` in cask names.
---
 Casks/font/font-m/font-m+-nerd-font.rb | 115 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 115 insertions(+)

diff --git a/Casks/font/font-m/font-m+-nerd-font.rb b/Casks/font/font-m/font-m+-nerd-font.rb
new file mode 100644
index 00000000000..8861822e153
--- /dev/null
+++ b/Casks/font/font-m/font-m+-nerd-font.rb
@@ -0,0 +1,115 @@
+cask "font-m+-nerd-font" do
+  version "3.2.1"
+  sha256 "2dfa4dedd98bbfe625ff56f0a31713aea77776aa7227bac300fd4246f2c79043"
+  
+  url "https://github.com/ryanoasis/nerd-fonts/releases/download/v#{version}/MPlus.zip"
+  name "M+ Nerd Font families (MPlus)"
+  homepage "https://github.com/ryanoasis/nerd-fonts"
+  
+  livecheck do
+    url :url
+    strategy :github_latest
+  end
+  
+  font "M+1CodeNerdFont-Bold.ttf"
+  font "M+1CodeNerdFont-ExtraLight.ttf"
[...]

@Finii
Copy link
Contributor Author

Finii commented Nov 18, 2024

"Of course" the renamed Cask had the wrong name inside 😬
Force push.

Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Finii!

@khipp khipp merged commit 65ed4cc into Homebrew:master Nov 18, 2024
145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants