Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tableau-*: use livecheck reference #192118

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

samford
Copy link
Member

@samford samford commented Nov 15, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

The various Tableau casks all contain an identical livecheck block that checks an upstream TableauAutoUpdate.xml file. The XML file only contains file information for Tableau Desktop, so that would suggest that these apps all use the same version if the in-app updater for each checks the same file.

Since the XML file lists information for Tableau Desktop, there's enough of a parent-child relationship between the tableau cask and the various tableau-* casks for us to simply use cask "tableau" in their livecheck blocks (instead of having to duplicate the same livecheck block in each). This will make it so that we only have to update the tableau livecheck block in the future (which may happen sooner or later, with regard to #191077 (review)).

@samford samford added ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. livecheck Issues or PRs related to livecheck labels Nov 15, 2024
@samford samford mentioned this pull request Nov 15, 2024
8 tasks
@khipp khipp merged commit 05b7f8f into master Nov 15, 2024
9 checks passed
@khipp khipp deleted the tableau-use-livecheck-reference branch November 15, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants