tableau-*: use livecheck reference #192118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.The various Tableau casks all contain an identical
livecheck
block that checks an upstreamTableauAutoUpdate.xml
file. The XML file only contains file information for Tableau Desktop, so that would suggest that these apps all use the same version if the in-app updater for each checks the same file.Since the XML file lists information for Tableau Desktop, there's enough of a parent-child relationship between the
tableau
cask and the varioustableau-*
casks for us to simply usecask "tableau"
in theirlivecheck
blocks (instead of having to duplicate the samelivecheck
block in each). This will make it so that we only have to update thetableau
livecheck
block in the future (which may happen sooner or later, with regard to #191077 (review)).