Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrlquaker-winbox: add compat check for Sequoia #187850

Merged

Conversation

belthesar
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Hey folks. First time doing an update to a cask with a case like this, so appreciate any guidance on what I may have messed up here.

We have a confirmed compatibility issue with Winbox-mac (nrlquaker-winbox) where new permission entitlements in macOS Sequoia are required to access the local network, but due to how the project is built, we do not have a straight forward go-ahead path to add this entitlement. Until we have a solution (or the project is retired, see nrlquaker/winbox-mac#155), I feel it's valuable to prevent net new installations on Sequoia systems.

In reading the cask and version documentation, I'm not sure if I also need to update the cask version or not to make this take effect. Appreciate any guidance on that. Thanks!

Casks/n/nrlquaker-winbox.rb Outdated Show resolved Hide resolved
@khipp khipp changed the title nrlquaker-winbox 3.41.0 - add compat check for Sequoia nrlquaker-winbox: add compat check for Sequoia Oct 8, 2024
@khipp khipp force-pushed the compat-nrlquaker-winbox-3.41.0-1 branch from 39fbdd3 to a5c70dc Compare October 8, 2024 19:19
@p-linnane p-linnane merged commit 7384eb9 into Homebrew:master Oct 9, 2024
8 checks passed
@belthesar belthesar deleted the compat-nrlquaker-winbox-3.41.0-1 branch October 9, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants