Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various [i] casks: add rosetta caveat #179654

Merged
merged 40 commits into from
Jul 17, 2024
Merged

Conversation

krehel
Copy link
Member

@krehel krehel commented Jul 16, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

@bevanjkay
Copy link
Member

@krehel Looks like ipsecuritas and infinity need to be dropped, and then we could go syntax-only.

@krehel
Copy link
Member Author

krehel commented Jul 16, 2024

Thanks - I'll tackle this when I get back to a laptop.

Signed-off-by: Justin Krehel <[email protected]>
Signed-off-by: Justin Krehel <[email protected]>
@krehel krehel force-pushed the various-add-rosetta-caveat-i branch from cd72ed6 to 7ac23c3 Compare July 16, 2024 18:45
@krehel
Copy link
Member Author

krehel commented Jul 16, 2024

audit for imgotv: failed

  • Version '6.4.16' differs from '' retrieved by livecheck.

@krehel krehel added ci-skip-livecheck Skip livecheck checks on CI. Use only for working checks that exclusively fail in the CI environment ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. labels Jul 16, 2024
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I went through the homepages and left some suggestions. By the looks of it, we could deprecate some of the casks. 😄

Casks/i/iphoto-library-manager.rb Outdated Show resolved Hide resolved
Casks/i/ipa-manager.rb Outdated Show resolved Hide resolved
Casks/i/internxt-drive.rb Outdated Show resolved Hide resolved
Casks/i/invesalius.rb Outdated Show resolved Hide resolved
Casks/i/invisiblix.rb Outdated Show resolved Hide resolved
Casks/i/iglance.rb Outdated Show resolved Hide resolved
Casks/i/icloud-control.rb Outdated Show resolved Hide resolved
Casks/i/icons8.rb Outdated Show resolved Hide resolved
Casks/i/igv.rb Outdated Show resolved Hide resolved
@krehel
Copy link
Member Author

krehel commented Jul 16, 2024

Feel free to push some updates! 😀 I'm batching into Rosetta, deprecate, and disable usually but I don't check every Cask repo or homepage. I plan to after I work through the Rosetta work.

@p-linnane p-linnane merged commit 450acc5 into master Jul 17, 2024
5 checks passed
@p-linnane p-linnane deleted the various-add-rosetta-caveat-i branch July 17, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip ci-skip-livecheck Skip livecheck checks on CI. Use only for working checks that exclusively fail in the CI environment ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants